Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications not working on Wordpress.com sites #9064

Closed
ryanbr opened this issue Apr 7, 2020 · 5 comments · Fixed by brave/brave-core#5288
Closed

Notifications not working on Wordpress.com sites #9064

ryanbr opened this issue Apr 7, 2020 · 5 comments · Fixed by brave/brave-core#5288

Comments

@ryanbr
Copy link

ryanbr commented Apr 7, 2020

Description

Visiting https://cookandcount.wordpress.com/ (while logged into wordpress.com) stops notifications from showing up.

Steps to Reproduce

  1. Login to wordpress.com first
  2. Then visit https://cookandcount.wordpress.com/
  3. With shields up, click on the Wordpress Bell on the top right.

Actual result:

wp-broken

Expected result:

With Allow all cookies / Shields Down.

wp-unbroken

Reproduces how often:

Easily

Brave version (brave://version info)

Version 1.5.123 Chromium: 80.0.3987.163 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Yes
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Tested in the referrer list: (without any luck)
"​​https://*.wordpress.com/*",
"https://*.wp.com/*",

Cookies being blocked:
wp-cookies

Allow all cookies is needed

@ryanbr ryanbr added webcompat/not-shields-related Sites are breaking because of something other than Shields. webcompat/shields Shields is breaking a website. workaround/allow-all-cookies feature/cookie-allow-list labels Apr 7, 2020
@ryanbr
Copy link
Author

ryanbr commented Apr 7, 2020

@pes The cookies being affected:

*.public-api.wordpress.com/wp_api
*.public-api.wordpress.com/wp_api_sec

Whitelisting these cookies seems to fix the wordpress notifications issues.

@pes10k
Copy link
Contributor

pes10k commented Apr 9, 2020

From slack convo:

@pes: The problem here is third party cookies. This seems crazy, but the reason why is that the side widget is an iframe pointing to widgets.wp.com, and that iframe tries to set up a websocket back to wordpress.com. Since that request to wordpress is 3p (relative to wp.com) the websocket setup request doesn’t carry cookies, and it falls over

@rebron
Copy link
Collaborator

rebron commented May 28, 2020

Screen Shot 2020-05-27 at 5 48 40 PM

verified works on version below following STR:

Brave 1.10.73 Chromium: 81.0.4044.138 (Official Build) beta (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS macOS Version 10.15.5 (Build 19F83c)

@rebron
Copy link
Collaborator

rebron commented May 28, 2020

Screen Shot 2020-05-27 at 5 53 09 PM

Verified works on Nightly version below following STR:

Brave 1.11.31 Chromium: 83.0.4103.61 (Official Build) nightly (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS macOS Version 10.15.5 (Build 19F83c)

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 28, 2020

Verification passed on


Brave | 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

  • Verified STR from the description
  • Verified with default shield settings Wordpress Bell notifications are shown

image


Verified passed with

Brave | 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Reproduced the issue using 1.9.72 and STR from description:

1 9 72 reproduce

  • Verified on upgrade profile that issue no longer reproduces:

1 9 76 upgrade

  • Verified STR from description on a clean profile with 1.9.76:

1 9 76 clean


Brave 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Linux
  • Verified STR from description on a clean and upgraded profile with 1.9.76

image

@rebron rebron changed the title Notifications not working on Wordpress site Notifications not working on Wordpress sites May 29, 2020
@rebron rebron changed the title Notifications not working on Wordpress sites Notifications not working on Wordpress.com sites May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants