Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blank new tab page #9111

Closed
rebron opened this issue Apr 9, 2020 · 3 comments · Fixed by brave/brave-core#5211
Closed

blank new tab page #9111

rebron opened this issue Apr 9, 2020 · 3 comments · Fixed by brave/brave-core#5211
Assignees
Labels
feature/new-tab OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Apr 9, 2020

Description

Blank new tab page, should not be blank. Likely introduced with this PR:
brave/brave-core#5097

Steps to Reproduce

  1. Open New Tab page with normal window. Notice that it's blank

Actual result:

Screen Shot 2020-04-09 at 9 18 18 AM

Screen Shot 2020-04-08 at 4 13 44 PM

Expected result:

Should see usual New Tab Page.

Reproduces how often:

Easily for effected profiles (likely older profiles, Top Sites related).

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Possible. Seen in 1.7.80 but blank ntp with 1.7.x could be a different issue.
  • Can you reproduce this issue with the beta channel? No, even though on 1.8.70 so due to a profile.
  • Can you reproduce this issue with the dev channel? 1.8.68
  • Can you reproduce this issue with the nightly channel? 1.9.x No, but again likely profile specific

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards?n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Not related to previous Empty NTP issue #8867

@rebron rebron added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Apr 9, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Apr 9, 2020

Adding release-notes/exclude as this hasn't made it into release yet.

@kjozwiak
Copy link
Member

@rebron mind checking this one we get a new 1.8.x now that brave/brave-core#5224 was approved and merged?

@kjozwiak
Copy link
Member

Labeling as QA/No as discussed before. We currently don't have STR that reproduces this 100%. Lets keep an eye on 1.8.x to make sure this doesn't happen/appear again.

@rebron @karenkliu confirmed that they're not seeing this problem anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/new-tab OS/Desktop priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants