Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty new tab page #8867

Closed
simonhong opened this issue Mar 26, 2020 · 1 comment · Fixed by brave/brave-core#5066
Closed

Empty new tab page #8867

simonhong opened this issue Mar 26, 2020 · 1 comment · Fixed by brave/brave-core#5066
Assignees
@NejcZdovc
Labels
bug feature/new-tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Milestone
1.7.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Mar 26, 2020 •
edited
Loading

After updating to 1.8.42 nightly, NTP rendered nothing like below.

Screen Shot 2020-03-26 at 12 36 23 PM

Screen Shot 2020-03-26 at 12 38 25 PM

Reproduce STEP.

  1. Launch with fresh profile
  2. Open NTP and only turn rewards On and wait NaN BAT is visible in reward widget.
  3. Launch again and can see empty NTP

Screen Shot 2020-03-26 at 1 59 50 PM
@NejcZdovc NejcZdovc mentioned this issue Mar 26, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc self-assigned this Mar 26, 2020
@NejcZdovc NejcZdovc added this to the 1.8.x - Nightly milestone Mar 26, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 26, 2020
@NejcZdovc
Fixes ntp blank page
1b5210c 
Resolves brave/brave-browser#8867
@LaurenWags LaurenWags mentioned this issue Mar 31, 2020
Closed
@brave-builds brave-builds mentioned this issue Mar 31, 2020
Merged
4 tasks
@LaurenWags LaurenWags mentioned this issue Apr 1, 2020
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Apr 1, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave 1.7.81 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified the STR from the description. Rewards widget no longer shows NaN and tab does not go blank on restart.

Verification passed on

Brave 1.7.81 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description. Rewards widget no longer shows NaN and tab does not go blank on restart.

Verification passed on

Brave 1.7.82 Chromium: 80.0.3987.162 (Official Build) dev (64-bit)
Revision f2c5dd6138153bb0658091205bd1a1717f16081a-refs/branch-heads/3987@{#1034}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the STR from the description. Rewards widget no longer shows NaN and tab does not go blank on restart.

@rebron rebron mentioned this issue Apr 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/new-tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.7.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes ntp blank page brave/brave-core
5 participants
@simonhong @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya