Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cookies in 1st-party iframes nested inside 3rd-party iframes when 3rd-party cookie blocking is enabled #9564

Closed
bridiver opened this issue Apr 30, 2020 · 1 comment · Fixed by brave/brave-core#5433
Closed

Allow cookies in 1st-party iframes nested inside 3rd-party iframes when 3rd-party cookie blocking is enabled #9564

bridiver opened this issue Apr 30, 2020 · 1 comment · Fixed by brave/brave-core#5433
Assignees
@bridiver
Labels
QA/No release-notes/include
Milestone
1.9.x - Release H...

Comments

@bridiver
Copy link
Contributor

bridiver commented Apr 30, 2020 •
edited by pes10k
Loading

Description

Currently we block storage on eTLD+1 frames, if they're nested in a non eTLD+1 equal frame. Eg in the below:

example.org
   <iframe src="other.org">
       <iframe src=example.org>

The example.org iframe would not get storage.

Brave should give storage to eTLD+1 = frames, irregardless of their position in a frame heirachy
bridiver added a commit to brave/brave-core that referenced this issue Apr 30, 2020
@bridiver
allow first party iframes embedded in 3rd-party origins plus exceptio…
35af0ec 
…ns for wp/wordpress and playstation/sonyentertainmentnetwork

fix brave/brave-browser#8629
fix brave/brave-browser#9564
@bridiver bridiver mentioned this issue Apr 30, 2020
Merged
32 tasks
@bridiver bridiver changed the title 1st-party iframes nested inside 3rd-party iframes have cookies blocked Cookies are blocked in 1st-party iframes nested inside 3rd-party iframes when 3rd-party cookie blocking is enabled Apr 30, 2020
@diracdeltas diracdeltas changed the title Cookies are blocked in 1st-party iframes nested inside 3rd-party iframes when 3rd-party cookie blocking is enabled allow cookies in 1st-party iframes nested inside 3rd-party iframes when 3rd-party cookie blocking is enabled Apr 30, 2020
bridiver added a commit to brave/brave-core that referenced this issue May 6, 2020
@bridiver
allow first party iframes embedded in 3rd-party origins plus exceptio…
8a70586 
…ns for wp/wordpress and playstation/sonyentertainmentnetwork

fix brave/brave-browser#8629
fix brave/brave-browser#9564
@bsclifton bsclifton added this to the 1.10.x - Nightly milestone May 7, 2020
@bsclifton bsclifton mentioned this issue May 7, 2020
Merged
4 tasks
This was referenced May 27, 2020
Closed
Closed
Closed
@LaurenWags
Copy link
Member

Marking as QA/Blocked until there is a test plan.

@rebron rebron added the QA/No label May 28, 2020
@rebron rebron changed the title allow cookies in 1st-party iframes nested inside 3rd-party iframes when 3rd-party cookie blocking is enabled Allow cookies in 1st-party iframes nested inside 3rd-party iframes when 3rd-party cookie blocking is enabled May 29, 2020
@LaurenWags LaurenWags mentioned this issue May 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bridiver bridiver

Labels
QA/No release-notes/include
Projects
None yet
Milestone
1.9.x - Release Hotfix 1
Development

Successfully merging a pull request may close this issue.

allow first party iframes embedded in 3rd-party origins plus exceptio… brave/brave-core
4 participants
@bridiver @bsclifton @rebron @LaurenWags