Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] User wallets not permitted up to a threshold of BAT earner #9723

Closed
mandar-brave opened this issue May 11, 2020 · 6 comments · Fixed by brave/brave-core#5986
Closed

Comments

@mandar-brave
Copy link

Details captured in the Android issue here: #9636

cc @bradleyrichter @jenn-rhim for opinion on any design specific changes.
This is a P2 that should hit BR on Desktop after prelim work.

@mandar-brave mandar-brave added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. labels May 11, 2020
@mandar-brave mandar-brave added priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Jun 30, 2020
@mandar-brave
Copy link
Author

mandar-brave commented Jun 30, 2020

Upgraded to a P1.

Logic:
Remove access to Uphold flow for any user unless the have 25 BAT in earnings
And allow an existing user to relogin from the Brave flow.

Expected UI change is in the Verify Wallet flow; for users under 25 BAT we need to allow an existing user who does not see the Verify Wallet message to Login. needs discussion @jenn-rhim

My suggestion is; keep the existing flows. If Client finds user has less than 25 BAT, we use the existing user flow to force a login vs. a verify (new user).

Details in spec for how to manage the flows.

cc @NejcZdovc @evq @jenn-rhim

@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned zenparsing Jul 1, 2020
@NejcZdovc NejcZdovc added this to the 1.12.x - Nightly milestone Jul 1, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 2, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 3, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 8, 2020
@NejcZdovc NejcZdovc removed this from the 1.12.x - Beta milestone Jul 8, 2020
@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 8, 2020
@rebron rebron changed the title Desktop change for user wallets via KYC [Desktop] Desktop change for user wallets via KYC Jul 20, 2020
@mandar-brave mandar-brave reopened this Jul 22, 2020
@mandar-brave
Copy link
Author

@NejcZdovc re-opening issue and restarting case flow from Android. In the discussion with Uphold, I missed updating the entire Android state flow here.

if user has <25 bat, they cannot verify a new wallet. Wallet needs to exist (this flow is working well) -- this seems like working as expected.
if user has <25 bat and not logged in with ID verified, all other flows (withdraw, add funds) need to be masked out. As in these flows need the user to re-login first to exist.

For a user is a pre-existing wallet user, and relogins back successfully, then enable Add-Funds and Withdraw.

Alternative path for user with < 25 BAT (for desktop only); keep Add Funds and Withdraw; any clicks with a non ID checked wallet forces user to login. Do not take user to verify wallet modal (that will create a lot of confusion and breaks logic of the minimal 25 BAT value)

cc @LaurenWags

@LaurenWags
Copy link
Member

fyi @srirambv on #9723 (comment) to confirm Android matches this expected result

@NejcZdovc
Copy link
Contributor

@mandar-brave closing this one as it was already merged, please open a new issue

@mandar-brave
Copy link
Author

@LaurenWags @srirambv there was no requirement for Android for the "relogin" use case as yet. Will file a P3 for Android separately.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 31, 2020

Verification passed on


Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Verified that click on Verify Wallet from the settings page opens up Cancel and Login pop up modal
image

  • Verified that click on Login redirects to Sign in to uphold
  • Verified that normal KYC uphold page is opened upon clicking on Verify wallet when wallet balance is greater than or equals to 25 BAT

image


Verification passed on

Brave 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

Verified that click on Verify Wallet from the settings page opens up Cancel and Login pop up modal
image
image

  • Verified that click on Login redirects to Sign in to uphold
  • Verified that normal KYC uphold page is opened upon clicking on Verify wallet when wallet balance is greater than or equals to 25 BAT
    image

Verified passed with

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-08-10 at 8 17 59 AM

Confirmed Cancel button closes the message box.
Confirmed Login button opens login page for Uphold.

This is the message that displays on brave://rewards page if you attempt to login with a non-KYC'd account:

Screen Shot 2020-08-10 at 7 53 30 AM

Confirmed close button closes the message box.

In addition to the test plan from above, also verified the following scenarios:

  1. Clean profile 1.12.x, 0 BAT bal, click on Verify wallet from panel - PASSED

    • confirm get login flow initially
    • confirm able to connect w/ KYC'd acct
    • after logging in with KYC'd acct, confirm able to disconnect/reconnect
  2. Clean profile 1.12.x with 25 BAT bal, click on Verify wallet from panel - PASSED

    • confirm get normal verify flow & modal
    • confirm able to connect w/ non-KYC'd acct
  3. KYC Account disconnect/reconnect with lower than threshold balance - PASSED

    • Clean install 1.12.x
    • Enable staging wallet and claim grant of 30 BAT
    • Tap on Verify Wallet
    • Login using a KYC'd account
    • Wallet connects successfully and shows Wallet verified on BR panel
    • Tip a verified publisher 5 BAT so balance becomes 25 BAT
    • Confirm able to disconnect wallet
    • Tip again so that balance goes below 25 BAT
    • Reconnect wallet when the balance is below 25 BAT and confirm still able to connect wallet
    • Tip the remaining BAT in the wallet to make the balance 0
    • Confirm disconnect wallet works fine
    • Confirm able to reconnect wallet even when wallet balance is 0
  4. Upgrade case 1 - PASSED

    • have KYC'd Uphold wallet connected on 1.11.x (no VG or user funds in wallet, it should all be Uphold BAT)
    • upgrade to 1.13.x
    • confirm still connected, was able to tip a KYC'd publisher without issue
    • after tip was completed, confirmed able to disconnect/reconnect
  5. Upgrade case 2 - PASSED

    • have KYC'd Uphold wallet connected on 1.11.x, manually disconnect (no VG or user funds in wallet, it should all be Uphold BAT)
    • upgrade to 1.13.x
    • confirm able to reconnect
  6. Wallet Claiming Case - PASSED

    • Install 1.12.x, enable rewards
    • Restore wallet with Ad grant waiting
    • Claim Ad grant + UGP grant
    • Click on Verify wallet and create a new, unverified account
    • Go thru KYC process
    • Once KYC process is complete, confirmed Brave Browser card created on Uphold and only Ad grant was successfully moved to Uphold wallet

Screen Shot 2020-08-10 at 9 03 40 AM

Screen Shot 2020-08-10 at 9 04 00 AM

Screen Shot 2020-08-10 at 9 04 31 AM

Screen Shot 2020-08-10 at 9 08 29 AM

@rebron rebron changed the title [Desktop] Desktop change for user wallets via KYC [Desktop] User wallets not permitted up to a threshold of BAT earner Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants