Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firebase authentication doesn't work with Brave #9852

Closed
jumde opened this issue May 20, 2020 · 4 comments
Closed

Firebase authentication doesn't work with Brave #9852

jumde opened this issue May 20, 2020 · 4 comments
Labels
OS/Windows QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields. workaround/allow-all-cookies
Milestone
1.12.x - Release #1

Comments

@jumde
Copy link
Contributor

jumde commented May 20, 2020

Description

From: #5869 (comment)

Steps to Reproduce

  1. Navigate to https://haynet.horse - Click Register

Actual result:

This browser is not supported or 3rd party cookies and data may be disabled.

Expected result:

Should register

Reproduces how often:

Easily

Brave version (brave://version info)

1.8.96 Chromium: 81.0.4044.138 (Official Build) (64-bit)
@jumde jumde added webcompat/not-shields-related Sites are breaking because of something other than Shields. workaround/allow-all-cookies labels May 20, 2020
@jumde jumde mentioned this issue May 20, 2020
Closed
@ryanbr
Copy link

ryanbr commented Jun 13, 2020

Its a Storage issue. Also seen here: https://www.rep2recall.net/

https://community.brave.com/t/firebase-auth-not-working-due-to-localstorage/134551

@ryanbr ryanbr mentioned this issue Jun 23, 2020
Closed
ryanbr added a commit to ryanbr/brave-core that referenced this issue Jun 24, 2020
@ryanbr
Fixes Firebase issues brave/brave-browser#10367 brave/brave-browser#9852
dce6837
@ryanbr ryanbr mentioned this issue Jun 24, 2020
Closed
6 tasks
@pes10k pes10k mentioned this issue Jun 25, 2020
Merged
@pes10k
Copy link
Contributor

pes10k commented Jun 26, 2020

closed with brave/brave-core#5952

@pes10k pes10k closed this as completed Jun 26, 2020
@pes10k pes10k added this to the 1.12.x - Nightly milestone Jun 26, 2020
@GeetaSarvadnya
Copy link

Verification passed on


Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)
  • Verified the STR from the description
  • Able to register https://haynet.horse/ with default shield settings
    image

@chrisjenx
Copy link

Awesome, thank you ❤️

@LaurenWags LaurenWags mentioned this issue Aug 11, 2020
Closed
@jumde jumde mentioned this issue Oct 19, 2020
Closed
@ryanbr ryanbr mentioned this issue Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/Windows QA Pass-Win64 QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields. workaround/allow-all-cookies
Projects
None yet
Milestone
1.12.x - Release #1
Development

No branches or pull requests
5 participants
@pes10k @chrisjenx @ryanbr @jumde @GeetaSarvadnya