-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 86 to Chromium 87. #11535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
mariospr
force-pushed
the
cr87
branch
2 times, most recently
from
September 7, 2020 09:42
2a06ce7
to
53f0de0
Compare
mariospr
force-pushed
the
cr87
branch
5 times, most recently
from
September 16, 2020 21:36
6ad66b7
to
767316d
Compare
mkarolin
changed the title
Upgrade from Chromium 86 to Chromium 87.
WIP: Upgrade from Chromium 86 to Chromium 87.
Oct 15, 2020
mkarolin
force-pushed
the
cr87
branch
3 times, most recently
from
October 20, 2020 16:06
3a167e5
to
d76dfa5
Compare
mkarolin
changed the title
WIP: Upgrade from Chromium 86 to Chromium 87.
Upgrade from Chromium 86 to Chromium 87.
Oct 20, 2020
bbondy
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but need to fix branch
bridiver
approved these changes
Oct 22, 2020
bridiver
reviewed
Oct 22, 2020
package.json
Outdated
"repository": { | ||
"url": "https://github.com/chromium/chromium" | ||
} | ||
}, | ||
"brave-core": { | ||
"dir": "src/brave", | ||
"branch": "master", | ||
"branch": "cr87", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget to change this back to master
mkarolin
force-pushed
the
cr87
branch
3 times, most recently
from
October 27, 2020 22:54
b5061e4
to
d2fc62e
Compare
mkarolin
added a commit
that referenced
this pull request
Nov 7, 2020
Upgrade from Chromium 86 to Chromium 87.
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11534
Related PR: brave/brave-core#6554
Submitter Checklist:
git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.