Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 93.0.4577.58 to Chromium 93.0.4577.63 (1.29.x). #17797

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Sep 1, 2021

Resolves #17790
Related PR: brave/brave-core#9939

Uplift from #17791

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Upgrade from Chromium 93.0.4577.58 to Chromium 93.0.4577.63
@kjozwiak
Copy link
Member

kjozwiak commented Sep 2, 2021

macOS failed due to RewardsContributionBrowserTest.SplitProcessOneTimeTip & RewardsContributionBrowserTest.SplitProcessorAutoContribution failing as per https://ci.brave.com/job/pr-brave-browser-93.0.4577.63-1.29.x-macos/2/testReport/. However, this is a known intermittent issue as per #13884 and doesn't block uplift.

macos-x64 / test-browser / RewardsContributionBrowserTest.SplitProcessOneTimeTip
macos-x64 / test-browser / RewardsContributionBrowserTest.SplitProcessorAutoContribution

@kjozwiak kjozwiak added this to the 1.29.x - Release #2 milestone Sep 2, 2021
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.29.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 0877e38 into 1.29.x Sep 2, 2021
@kjozwiak kjozwiak deleted the 93.0.4577.63-1.29.x branch September 2, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants