-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add support for Chromecast #4631
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
jumde
reviewed
May 28, 2019
diracdeltas
requested changes
May 28, 2019
bsclifton
force-pushed
the
readd-chromecast
branch
2 times, most recently
from
May 29, 2019 05:21
e41144c
to
efdc1fe
Compare
diracdeltas
previously approved these changes
May 29, 2019
bsclifton
changed the title
WIP: Re-add support for Chromecast
Re-add support for Chromecast
Jun 5, 2019
brave-builds
force-pushed
the
readd-chromecast
branch
2 times, most recently
from
June 19, 2019 00:32
759fb18
to
d7ac5a9
Compare
diracdeltas
reviewed
Jun 20, 2019
lib/whitelistedUrlPrefixes.js
Outdated
'https://publishers-staging-distro.basicattentiontoken.org/' | ||
'https://publishers-staging-distro.basicattentiontoken.org/', | ||
'https://extensionupdater.brave.com/', | ||
'https://clients2.google.com/' // allowed because it 307's to https://extensionupdater.brave.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we be more specific with this prefix based on brave/brave-core#2493 (comment)?
for instance https://clients2.google.com/service/update2/crx
brave-builds
force-pushed
the
readd-chromecast
branch
from
June 20, 2019 20:31
ff7cec2
to
feb3a2d
Compare
jumde
force-pushed
the
readd-chromecast
branch
2 times, most recently
from
June 25, 2019 21:53
fed6e3a
to
6602e85
Compare
jumde
force-pushed
the
readd-chromecast
branch
2 times, most recently
from
July 3, 2019 17:42
091d6de
to
89aab42
Compare
brave-builds
force-pushed
the
readd-chromecast
branch
from
July 3, 2019 23:03
89aab42
to
86baea9
Compare
brave-builds
force-pushed
the
readd-chromecast
branch
from
July 4, 2019 00:18
46c9f96
to
1f153fa
Compare
brave-builds
force-pushed
the
readd-chromecast
branch
from
July 8, 2019 08:45
b35ae47
to
7b9f266
Compare
simonhong
force-pushed
the
readd-chromecast
branch
from
July 8, 2019 12:12
7b9f266
to
aae565b
Compare
brave-builds
force-pushed
the
readd-chromecast
branch
from
July 9, 2019 17:35
923f089
to
7f4a8dd
Compare
jumde
force-pushed
the
readd-chromecast
branch
4 times, most recently
from
July 13, 2019 19:26
a1c09bc
to
7ba9ecb
Compare
brave-builds
force-pushed
the
readd-chromecast
branch
from
July 15, 2019 18:53
7ba9ecb
to
c7d58f9
Compare
jumde
force-pushed
the
readd-chromecast
branch
3 times, most recently
from
July 18, 2019 23:14
1632858
to
18ee7b3
Compare
brave-builds
force-pushed
the
readd-chromecast
branch
from
July 22, 2019 07:00
18ee7b3
to
752ff3b
Compare
CLOSING - this is no longer needed 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209
Dependencies
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.