Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 80.0.3987.85 to Chromium 80.0.3987.87 (1.5.x). #8081

Merged
merged 1 commit into from
Feb 6, 2020

Conversation

mkarolin
Copy link
Contributor

@mkarolin mkarolin commented Feb 5, 2020

Fixes #8058
Related PR: brave/brave-core#4521
Uplift from #8064

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Upgrade from Chromium 80.0.3987.85 to Chromium 80.0.3987.87.
@mkarolin mkarolin added this to the 1.5.x - Dev milestone Feb 5, 2020
@mkarolin mkarolin self-assigned this Feb 5, 2020
@mkarolin mkarolin marked this pull request as ready for review February 5, 2020 21:51
@mkarolin mkarolin requested a review from a team February 6, 2020 00:28
@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2020

Both Linux & macOS failed audit-network which is a known issue and not specific to this PR:

Looks like build failed on Win x64 due to the agent being removed so going to restart:

17:52:45  Cannot contact i-0849d488a17683a0a: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel
17:57:50  Could not connect to i-0849d488a17683a0a to send interrupt signal to process

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. As per brave/brave-core#4521 (comment), the only failures are due to audit-network on macOS and Linux which is a known issue.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit ba0c1be into 1.5.x Feb 6, 2020
@kjozwiak kjozwiak deleted the 80.0.3987.87-1.5.x branch February 6, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants