Skip to content

Commit

Permalink
Merge pull request #7306 from brave/fixup-7247
Browse files Browse the repository at this point in the history
Fix perf predictor tab helper tests after #7247
  • Loading branch information
bbondy authored Dec 2, 2020
2 parents 2534f63 + 05d5150 commit 05642aa
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ IN_PROC_BROWSER_TEST_F(PerfPredictorTabHelperTest, NoBlockNoSavings) {

EXPECT_EQ(true, EvalJs(contents,
"addImage('logo.png');"
"setExpectations(0, 0, 0, 0, 1, 0);"
"setExpectations(0, 0, 1, 0);"
"xhr('analytics.js')"));
// Prediction triggered when web contents are closed
contents->Close();
Expand All @@ -100,7 +100,7 @@ IN_PROC_BROWSER_TEST_F(PerfPredictorTabHelperTest, ScriptBlockHasSavings) {

EXPECT_EQ(true, EvalJs(contents,
"addImage('logo.png');"
"setExpectations(0, 0, 0, 0, 0, 1);"
"setExpectations(0, 0, 0, 1);"
"xhr('analytics.js')"));

EXPECT_EQ(getProfileAdsBlocked(browser()), 1ULL);
Expand All @@ -121,7 +121,7 @@ IN_PROC_BROWSER_TEST_F(PerfPredictorTabHelperTest, NewNavigationStoresSavings) {

EXPECT_EQ(true, EvalJs(contents,
"addImage('logo.png');"
"setExpectations(0, 0, 0, 0, 0, 1);"
"setExpectations(0, 0, 0, 1);"
"xhr('analytics.js')"));
EXPECT_EQ(getProfileAdsBlocked(browser()), 1ULL);
// Prediction triggered when web contents are closed
Expand All @@ -130,7 +130,7 @@ IN_PROC_BROWSER_TEST_F(PerfPredictorTabHelperTest, NewNavigationStoresSavings) {
ui_test_utils::NavigateToURL(browser(), second_url);
EXPECT_EQ(true, EvalJs(contents,
"addImage('logo.png');"
"setExpectations(0, 0, 0, 0, 0, 1);"
"setExpectations(0, 0, 0, 1);"
"xhr('analytics.js')"));

auto previous_nav_savings = getProfileBandwidthSaved(browser());
Expand Down

0 comments on commit 05642aa

Please sign in to comment.