Skip to content

Commit

Permalink
Temporarily disables WindowClosingConfirmBrowserTest.TestWithDownload…
Browse files Browse the repository at this point in the history
… on MacOS.

The test fails because in Chromium Private/Incognito profiles now ignore the
"Ask for download location" setting and always prompt for the location.
We will fix that in brave/brave-browser#29823,
but until then let's disable this test on MacOS.
  • Loading branch information
mkarolin committed Apr 28, 2023
1 parent 07001f7 commit 29f828b
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion browser/ui/window_closing_confirm_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,15 @@ IN_PROC_BROWSER_TEST_F(WindowClosingConfirmBrowserTest,
ui_test_utils::WaitForBrowserToClose(brave_browser);
}

IN_PROC_BROWSER_TEST_F(WindowClosingConfirmBrowserTest, TestWithDownload) {
// Temporarily disable the test on MacOS until
// https://github.com/brave/brave-browser/issues/29823 is fixed.
#if BUILDFLAG(IS_MAC)
#define MAYBE_TestWithDownload DISABLED_TestWithDownload
#else
#define MAYBE_TestWithDownload TestWithDownload
#endif
IN_PROC_BROWSER_TEST_F(WindowClosingConfirmBrowserTest,
MAYBE_TestWithDownload) {
// On macOS, download in-progress warning is not shown for normal profile window
// closing as it can still continue after window is closed.
// However, private profile window works like normal window of other platforms.
Expand Down

0 comments on commit 29f828b

Please sign in to comment.