Skip to content

Commit

Permalink
Implemented IPFS import refactoring
Browse files Browse the repository at this point in the history
Removed File/Text/Directory import classes.
Use base class instead, moved blob creation to network utilities
  • Loading branch information
spylogsster committed May 14, 2021
1 parent 6302bd6 commit 33a4964
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 1 deletion.
18 changes: 18 additions & 0 deletions components/ipfs/ipfs_network_utils.cc
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,10 @@ std::unique_ptr<storage::BlobDataBuilder> BuildBlobWithFolder(

namespace ipfs {

<<<<<<< HEAD
=======

>>>>>>> 8ba05e73c8 (Implemented IPFS import refactoring)
std::unique_ptr<network::SimpleURLLoader> CreateURLLoader(
const GURL& gurl,
const std::string& method,
Expand Down Expand Up @@ -248,20 +252,34 @@ void CreateRequestForFile(const base::FilePath& upload_file_path,
size_t file_size) {
std::string mime_boundary = net::GenerateMimeMultipartBoundary();
auto blob_builder_callback =
<<<<<<< HEAD
base::BindOnce(&BuildBlobWithFile, upload_file_path, mime_type, filename,
mime_boundary, file_size);
=======
base::BindOnce(&BuildBlobWithFile, upload_file_path, mime_type,
filename, mime_boundary, file_size);
>>>>>>> 8ba05e73c8 (Implemented IPFS import refactoring)
std::string content_type = ipfs::kIPFSImportMultipartContentType;
content_type += " boundary=";
content_type += mime_boundary;

base::PostTaskAndReplyWithResult(
FROM_HERE, {base::MayBlock(), content::BrowserThread::IO},
base::BindOnce(&CreateResourceRequest, std::move(blob_builder_callback),
<<<<<<< HEAD
content_type, std::move(storage)),
std::move(request_callback));
}

std::vector<ImportFileInfo> EnumerateDirectoryFiles(base::FilePath dir_path) {
=======
content_type, std::move(storage)),
std::move(request_callback));
}

std::vector<ImportFileInfo> EnumerateDirectoryFiles(
base::FilePath dir_path) {
>>>>>>> 8ba05e73c8 (Implemented IPFS import refactoring)
std::vector<ImportFileInfo> files;
base::FileEnumerator file_enum(
dir_path, true,
Expand Down
4 changes: 3 additions & 1 deletion components/ipfs/ipfs_network_utils_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,13 @@
#include "services/network/public/cpp/data_element.h"
#include "storage/browser/blob/blob_data_builder.h"
#include "storage/browser/blob/blob_data_item.h"

#include "services/network/public/cpp/data_element.h"
#include "testing/gtest/include/gtest/gtest.h"

namespace ipfs {

class IpfsNetwrokUtilsUnitTest : public testing::Test {
class IpfsNetwrokUtilsUnitTest : public ChromeRenderViewHostTestHarness {
public:
IpfsNetwrokUtilsUnitTest() {}
~IpfsNetwrokUtilsUnitTest() override = default;
Expand Down

0 comments on commit 33a4964

Please sign in to comment.