-
Notifications
You must be signed in to change notification settings - Fork 868
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use temporal AutocompleteClassifier to get proper navigation url
To get proper selection navigation url for profile, use tempral AutocompleteClassfier. We can't use AutocompleteClassifierFactory for this because AutocompleteClassifierFactory doesn't create service for otr profile. But we need different navigation url for OTR profile.
- Loading branch information
Showing
10 changed files
with
44 additions
and
146 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 0 additions & 44 deletions
44
browser/autocomplete/brave_autocomplete_provider_client_browsertest.cc
This file was deleted.
Oops, something went wrong.
30 changes: 0 additions & 30 deletions
30
browser/autocomplete/brave_autocomplete_provider_client_for_classifier.cc
This file was deleted.
Oops, something went wrong.
44 changes: 0 additions & 44 deletions
44
browser/autocomplete/brave_autocomplete_provider_client_for_classifier.h
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 0 additions & 17 deletions
17
patches/chrome-browser-autocomplete-autocomplete_classifier_factory.cc.patch
This file was deleted.
Oops, something went wrong.
12 changes: 12 additions & 0 deletions
12
patches/chrome-browser-renderer_context_menu-render_view_context_menu.cc.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc | ||
index fd1135cead69374786578e274ad0762801aa0440..3fa2d2c993b54a062dc8756861dee1ea2e2abd5b 100644 | ||
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc | ||
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc | ||
@@ -1649,6 +1649,7 @@ void RenderViewContextMenu::AppendSearchProvider() { | ||
selection_navigation_url_ = match.destination_url; | ||
if (!selection_navigation_url_.is_valid()) | ||
return; | ||
+ BRAVE_APPEND_SEARCH_PROVIDER | ||
|
||
base::string16 printable_selection_text = PrintableSelectionText(); | ||
EscapeAmpersands(&printable_selection_text); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters