Skip to content

Commit

Permalink
Use std::move instead of base::Passed with base::BindOnce.
Browse files Browse the repository at this point in the history
Chromium change:

https://source.chromium.org/chromium/chromium/src/+/64da068f017ecd585a60f420f98270b3469397c1

commit 64da068f017ecd585a60f420f98270b3469397c1
Author: Daniel Cheng <[email protected]>
Date:   Tue Mar 16 07:30:09 2021 +0000

    [base] Disallow base::BindOnce() + base::Passed() everywhere.

    std::move() and base::Passed() mean the same thing for base::BindOnce(),
    so use the standard library idiom instead.

    Bug: 1180750
  • Loading branch information
mkarolin authored and mariospr committed May 5, 2021
1 parent 3a39696 commit 359aec3
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ - (void)importFromFile:(NSString*)filePath
// Import into the Profile/ChromeBrowserState on the main-thread.
base::PostTask(
FROM_HERE, {web::WebThread::UI},
base::BindOnce(complete_import, base::Passed(std::move(bookmarks)),
base::BindOnce(complete_import, std::move(bookmarks),
top_level_folder_name, listener));
} else {
listener(BraveBookmarksImporterStateCompleted,
Expand Down
3 changes: 1 addition & 2 deletions vendor/brave-ios/Ads/BATBraveAds.mm
Original file line number Diff line number Diff line change
Expand Up @@ -1159,8 +1159,7 @@ - (void)runDBTransaction:(ads::DBTransactionPtr)transaction
base::PostTaskAndReplyWithResult(
databaseQueue.get(),
FROM_HERE,
base::BindOnce(&RunDBTransactionOnTaskRunner,
base::Passed(std::move(transaction)),
base::BindOnce(&RunDBTransactionOnTaskRunner, std::move(transaction),
adsDatabase),
base::BindOnce(^(ads::DBCommandResponsePtr response) {
const auto strongSelf = weakSelf;
Expand Down
3 changes: 1 addition & 2 deletions vendor/brave-ios/Ledger/BATBraveLedger.mm
Original file line number Diff line number Diff line change
Expand Up @@ -1871,8 +1871,7 @@ - (void)runDBTransaction:(ledger::type::DBTransactionPtr)transaction
base::PostTaskAndReplyWithResult(
databaseQueue.get(),
FROM_HERE,
base::BindOnce(&RunDBTransactionOnTaskRunner,
base::Passed(std::move(transaction)),
base::BindOnce(&RunDBTransactionOnTaskRunner, std::move(transaction),
rewardsDatabase),
base::BindOnce(^(ledger::type::DBCommandResponsePtr response) {
if (weakSelf)
Expand Down

0 comments on commit 359aec3

Please sign in to comment.