Skip to content

Commit

Permalink
Disables TrustTokens feature.
Browse files Browse the repository at this point in the history
Also, disables the origin trial.

Fixes brave/brave-browser#13886
  • Loading branch information
mkarolin committed May 18, 2021
1 parent bedea31 commit 383d187
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions app/brave_main_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,7 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
federated_learning::kFederatedLearningOfCohorts.name,
federated_learning::kFlocIdComputedEventLogging.name,
net::features::kFirstPartySets.name,
network::features::kTrustTokens.name,
network_time::kNetworkTimeServiceQuerying.name,
#if defined(OS_ANDROID)
features::kWebNfc.name,
Expand Down
1 change: 1 addition & 0 deletions app/brave_main_delegate_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&federated_learning::kFlocIdComputedEventLogging,
&kEnableProfilePickerOnStartupFeature,
&net::features::kFirstPartySets,
&network::features::kTrustTokens,
&network_time::kNetworkTimeServiceQuerying,
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ bool IsTrialDisabledInBrave(const StringView& trial_name) {
"DigitalGoods",
"SignedExchangeSubresourcePrefetch",
"SubresourceWebBundles",
"TrustTokens",
};

if (base::Contains(kBraveDisabledTrialNames, trial_name)) {
Expand All @@ -38,10 +39,11 @@ bool IsTrialDisabledInBrave(const StringView& trial_name) {

bool IsTrialDisabledInBrave(OriginTrialFeature feature) {
// When updating also update the array in the overload above.
static const std::array<OriginTrialFeature, 3> kBraveDisabledTrialFeatures = {
static const std::array<OriginTrialFeature, 4> kBraveDisabledTrialFeatures = {
OriginTrialFeature::kDigitalGoods,
OriginTrialFeature::kSignedExchangeSubresourcePrefetch,
OriginTrialFeature::kSubresourceWebBundles,
OriginTrialFeature::kTrustTokens,
};

return base::Contains(kBraveDisabledTrialFeatures, feature);
Expand Down

0 comments on commit 383d187

Please sign in to comment.