Skip to content

Commit

Permalink
Disables TrustTokens feature.
Browse files Browse the repository at this point in the history
Also, disables the feature in blink and origin trials.

Fixes brave/brave-browser#13886
  • Loading branch information
mkarolin committed Feb 12, 2021
1 parent 4869c2a commit 522fc78
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions app/brave_main_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
features::kSubresourceWebBundles.name,
features::kTabHoverCards.name,
features::kWebOTP.name,
network::features::kTrustTokens.name,
network_time::kNetworkTimeServiceQuerying.name,
safe_browsing::kEnhancedProtection.name,
#if defined(OS_ANDROID)
Expand Down
1 change: 1 addition & 0 deletions app/brave_main_delegate_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&features::kSubresourceWebBundles,
&features::kTabHoverCards,
&features::kWebOTP,
&network::features::kTrustTokens,
&network_time::kNetworkTimeServiceQuerying,
&safe_browsing::kEnhancedProtection,
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ bool IsTrialDisabledInBrave(const StringView& trial_name) {
"DigitalGoods",
"SignedExchangeSubresourcePrefetch",
"SubresourceWebBundles",
"TrustTokens",
};

if (base::Contains(kBraveDisabledTrialNames, trial_name)) {
Expand All @@ -38,10 +39,11 @@ bool IsTrialDisabledInBrave(const StringView& trial_name) {

bool IsTrialDisabledInBrave(OriginTrialFeature feature) {
// When updating also update the array in the overload above.
static const std::array<OriginTrialFeature, 3> kBraveDisabledTrialFeatures = {
static const std::array<OriginTrialFeature, 4> kBraveDisabledTrialFeatures = {
OriginTrialFeature::kDigitalGoods,
OriginTrialFeature::kSignedExchangeSubresourcePrefetch,
OriginTrialFeature::kSubresourceWebBundles,
OriginTrialFeature::kTrustTokens,
};

return base::Contains(kBraveDisabledTrialFeatures, feature);
Expand Down
3 changes: 3 additions & 0 deletions renderer/brave_content_renderer_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ SetRuntimeFeaturesDefaultsBeforeBlinkInitialization() {
blink::WebRuntimeFeatures::EnableFeatureFromString(
"FileSystemAccessAPIExperimental", false);
blink::WebRuntimeFeatures::EnableFeatureFromString("Serial", false);
blink::WebRuntimeFeatures::EnableFeatureFromString("TrustTokens", false);
blink::WebRuntimeFeatures::EnableFeatureFromString(
"TrustTokensAlwaysAllowIssuance", false);
}

BraveContentRendererClient::~BraveContentRendererClient() = default;
Expand Down

0 comments on commit 522fc78

Please sign in to comment.