Skip to content

Commit

Permalink
Merge pull request #52 from brave/welcome-fixes
Browse files Browse the repository at this point in the history
Welcome page fixes
  • Loading branch information
bbondy authored Mar 5, 2018
2 parents 0f39310 + e14fd43 commit 644233d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
10 changes: 7 additions & 3 deletions browser/brave_content_browser_client.cc
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@
namespace {

bool HandleURLRewrite(GURL* url,
content::BrowserContext* browser_context) {
content::BrowserContext* browser_context) {
if (url->SchemeIs(content::kChromeUIScheme) &&
url->host() == chrome::kChromeUIWelcomeHost) {
(url->host() == chrome::kChromeUIWelcomeHost ||
url->host() == chrome::kChromeUIWelcomeWin10Host)) {
*url = GURL(kWelcomeRemoteURL);
return true;
}
Expand All @@ -30,12 +31,15 @@ bool HandleURLRewrite(GURL* url,
}

bool HandleURLReverseRewrite(GURL* url,
content::BrowserContext* browser_context) {
content::BrowserContext* browser_context) {
// Handle mapping new tab URL to ourselves
if (url->SchemeIs(content::kChromeUIScheme) &&
url->host() == chrome::kChromeUINewTabHost) {
return true;
}
if (url->spec() == kWelcomeRemoteURL) {
return true;
}
return false;
}

Expand Down
2 changes: 1 addition & 1 deletion common/webui_url_constants.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
const char kPaymentsHost[] = "payments";
const char kPaymentsJS[] = "brave_payments.js";
const char kBraveNewTabJS[] = "brave_new_tab.js";
const char kWelcomeRemoteURL[] = "https://brave.com/welcome.html";
const char kWelcomeRemoteURL[] = "https://brave.com/welcome/";

0 comments on commit 644233d

Please sign in to comment.