Skip to content

Commit

Permalink
Fixes save password prompt.
Browse files Browse the repository at this point in the history
Fixes brave/brave-browser#12398

Image files we were overriding got renamed.

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/39eded942d854f367be5bde332189a6a8271c76f

commit 39eded942d854f367be5bde332189a6a8271c76f
Author: Mohamed Amir Yosef <[email protected]>
Date:   Tue Sep 22 17:27:02 2020 +0000

    [Passwords] Update header image for different states in Save Bubble

    As per the attached bug, here is the logic for changing the header image

    - The illustration should change when the user switches between "Save to device" and "Sav  to account".
    - In the Update bubble, the illustration should change based on where the update will go.
    - If the update will go to both locations, use the "account" image.

    Screencast:
    Light mode: https://screencast.googleplex.com/cast/NjQxNjYzNjU3MzY0Njg0OHw0NTg2MTgzYy1kMw
    Dark mode: https://screencast.googleplex.com/cast/NTY4MTQ3NTYxMTUyNTEyMHwzOTI4Y2JkYy1mZQ

    Bug: 1115936
  • Loading branch information
mkarolin committed Oct 29, 2020
1 parent ef9ed2a commit 691f86a
Show file tree
Hide file tree
Showing 8 changed files with 0 additions and 0 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 691f86a

Please sign in to comment.