Fix #12492: Disable idle detection API

brave · Nov 5, 2020 · c1bad8e · c1bad8e
1 parent f45197c
commit c1bad8e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/app/brave_main_delegate.cc b/app/brave_main_delegate.cc
@@ -227,6 +227,7 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
     autofill::features::kAutofillServerCommunication.name,
     blink::features::kTextFragmentAnchor.name,
     features::kAllowPopupsDuringPageUnload.name,
+    features::kIdleDetection.name,
     features::kNotificationTriggers.name,
     features::kPrivacySettingsRedesign.name,
     features::kSignedExchangeSubresourcePrefetch.name,

diff --git a/app/brave_main_delegate_browsertest.cc b/app/brave_main_delegate_browsertest.cc
@@ -66,6 +66,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
       &autofill::features::kAutofillServerCommunication,
       &blink::features::kTextFragmentAnchor,
       &features::kAllowPopupsDuringPageUnload,
+      &features::kIdleDetection,
       &features::kNotificationTriggers,
       &features::kPrivacySettingsRedesign,
       &features::kSignedExchangeSubresourcePrefetch,

diff --git a/...rc/org/chromium/components/browser_ui/site_settings/BraveSiteSettingsPreferencesBase.java b/...rc/org/chromium/components/browser_ui/site_settings/BraveSiteSettingsPreferencesBase.java
@@ -20,6 +20,7 @@ public class BraveSiteSettingsPreferencesBase extends SiteSettingsPreferenceFrag
     private static final String BACKGROUND_SYNC_KEY = "background_sync";
     private static final String PLAY_YT_VIDEO_IN_BROWSER_KEY = "play_yt_video_in_browser";
     private static final String DESKTOP_MODE_KEY = "desktop_mode";
+    private static final String IDLE_DETECTION = "idle_detection";
 
     private final HashMap<String, Preference> mRemovedPreferences = new HashMap<>();
 
@@ -65,6 +66,7 @@ private void removePreferenceIfPresent(String key) {
     }
 
     private void configureBravePreferences() {
+        removePreferenceIfPresent(IDLE_DETECTION);
         removePreferenceIfPresent(ADS_KEY);
         removePreferenceIfPresent(BACKGROUND_SYNC_KEY);
     }