-
Notifications
You must be signed in to change notification settings - Fork 869
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Moved call to create Brave config into config_factory.py. Added a static method to our config creation to prevent an exception when Chrome's config loading is attempted. Maybe need to add code to throw an exception when provisioning profile is not found from the env when not a development config, but development var isn't passed into the config_factory which means we'd need to add another patch. Chromium change: https://chromium.googlesource.com/chromium/src/+/f21027ab4d74ea035d98bbf6ba77e8fa148f08b5 commit f21027ab4d74ea035d98bbf6ba77e8fa148f08b5 Author: Joshua Pawlicki <[email protected]> Date: Mon Mar 23 17:45:15 2020 +0000 Create an updater-specific signing pipeline. Bug: 926234
- Loading branch information
Showing
3 changed files
with
26 additions
and
38 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
13 changes: 13 additions & 0 deletions
13
patches/chrome-installer-mac-signing-config_factory.py.patch
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/chrome/installer/mac/signing/config_factory.py b/chrome/installer/mac/signing/config_factory.py | ||
index 0689fb6476e741b711454aeaf4ac7c20d5e4f989..c303bb474dcf4036fc1e8d8b6985af20ae2e4f62 100644 | ||
--- a/chrome/installer/mac/signing/config_factory.py | ||
+++ b/chrome/installer/mac/signing/config_factory.py | ||
@@ -8,6 +8,8 @@ def get_class(): | ||
# First look up the processed Chromium config. | ||
from chromium_config import ChromiumCodeSignConfig | ||
config_class = ChromiumCodeSignConfig | ||
+ from signing_helper import GetBraveSigningConfig | ||
+ config_class = GetBraveSigningConfig(config_class) | ||
|
||
# Then search for the internal config for Google Chrome. | ||
try: |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters