Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch and cache region list at startup #10031

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Sep 10, 2021

fix: brave/brave-browser#17985
fix: brave/brave-browser#17899

With cached region list, service can give region list to webui quickly.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong self-assigned this Sep 10, 2021
@simonhong simonhong force-pushed the vpn_service_fetch_region_list branch 2 times, most recently from f37cbf1 to c0ca695 Compare September 10, 2021 03:49
Copy link
Contributor

@nullhook nullhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fix: brave/brave-browser#17985

With cached region list, service can give region list to webui quickly.
@simonhong simonhong merged commit 7e059d8 into master Sep 10, 2021
@simonhong simonhong deleted the vpn_service_fetch_region_list branch September 10, 2021 08:37
@simonhong simonhong added this to the 1.31.x - Nightly milestone Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makes VPN Service fetch/cache region list Get all regions in desktop vpn service and expose to mojom
2 participants