Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade typescript to 4.4 #10827

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Upgrade typescript to 4.4 #10827

merged 1 commit into from
Nov 8, 2021

Conversation

petemill
Copy link
Member

@petemill petemill commented Nov 2, 2021

Resolves brave/brave-browser#19191

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

@nullhook nullhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I will also migrate from tslint to eslint

@petemill
Copy link
Member Author

petemill commented Nov 5, 2021

CI all green apart from macos at the security lock-keychain which is apparently OK to merge as unrelated and already passed build step successfully.

Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@petemill
Copy link
Member Author

petemill commented Nov 7, 2021

Only failure on this is a known macOS unrelated step, after build and tests.

@petemill petemill removed the request for review from szilardszaloki November 7, 2021 22:52
@nullhook nullhook mentioned this pull request Nov 8, 2021
24 tasks
@petemill petemill merged commit 9b734cd into master Nov 8, 2021
@petemill petemill deleted the typescript-444 branch November 8, 2021 15:14
@petemill petemill added this to the 1.33.x - Nightly milestone Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript is out of date
4 participants