Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix this.$$ is not a function error in wallet_networks_subpage's noti… #10891

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Nov 5, 2021

…fyKeylist

Resolves brave/brave-browser#19239

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Visit brave://settings/wallet/networks and add new networks should not have any console error.

@yrliou yrliou added this to the 1.33.x - Nightly milestone Nov 5, 2021
@yrliou yrliou requested a review from petemill November 5, 2021 00:25
@yrliou yrliou self-assigned this Nov 5, 2021
@yrliou
Copy link
Member Author

yrliou commented Nov 5, 2021

macOS has irrelevant error in S3 upload, merging.

@yrliou yrliou merged commit b08d0ab into master Nov 5, 2021
@yrliou yrliou deleted the fix_add_network_console_error branch November 5, 2021 03:36
mkarolin pushed a commit that referenced this pull request Nov 5, 2021
Fix this.$$ is not a function error in wallet_networks_subpage's noti…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console error when adding new networks via brave://settings/wallet/networks
2 participants