Fix confusing content settings #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antimuon changes for: https://github.com/brave/brave/issues/42
bridiver
reviewed
Dec 29, 2017
| @@ -0,0 +1,18 @@ | |||
| /* This Source Code Form is subject to the terms of the Mozilla Public | |||
There was a problem hiding this comment.
since they are a kind of sub-content type, I'm thinking that we should just call this file brave_shields/common/brave_shield_constants.h to be consistent with other constants files
There was a problem hiding this comment.
Will do and merge with shield_types.h
bridiver
reviewed
Dec 29, 2017
|
|
||
| if (setting == CONTENT_SETTING_DEFAULT) { | ||
| if (resource_identifier == "ads") { | ||
| return false; |
There was a problem hiding this comment.
should the top level shield settings be preferences?
There was a problem hiding this comment.
will come in the future, will add a comment for now
antonok-edm
added a commit
that referenced
this pull request
Mar 10, 2021
Update adblock-rust to 0.2.1 with optional CSS validation
mariospr
added a commit
that referenced
this pull request
Jun 25, 2021
Don't initialize callbacks from HistogramsBraveizer's constructor.
Initializing all the StatisticsRecorder::ScopedHistogramSampleObserver
objects for each histogram from the constructor would be too early and
will cause crashes on DCHECK-enabled builds, like the following one:
[2883544:2883544:0624/122638.724689:FATAL:bind_internal.h(843)]
Check failed: receiver->HasAtLeastOneRef(). base::Bind{Once,Repeating}()
refuses to create the first reference to ref-counted objects. That typically
happens around PostTask() in their constructor, and such objects can be
destroyed before `new` returns if the task resolves fast enough.
#0 0x7faa83f3c119 base::debug::CollectStackTrace()
#1 0x7faa83e389d3 base::debug::StackTrace::StackTrace()
#2 0x7faa83e59cc4 logging::LogMessage::~LogMessage()
#3 0x7faa83e5a70e logging::LogMessage::~LogMessage()
#4 0x563a89be9924 _ZN4base8internal34BanUnconstructedRefCountedReceiverIMN10[...]
#5 0x563a8a4e6f40 base::internal::BindState<>::Create<>()
#6 0x563a8a4e6a91 brave::HistogramsBraveizer::InitCallbacks()
#7 0x563a8a96f0bf BraveBrowserProcessImpl::BraveBrowserProcessImpl()
#8 0x563a8a73eaee ChromeBrowserMainParts::PreEarlyInitialization()
#9 0x563a8aad13e5 ChromeBrowserMainPartsPosix::PreEarlyInitialization()
#10 0x7faa817a6952 content::BrowserMainLoop::EarlyInitialization()
#11 0x7faa817aaa2b content::BrowserMainRunnerImpl::Initialize()
[...]
Therefore, this patch delays the initialization of the callbacks
until the HistogramsBraveizer object is properly constructed, by
using an static Create method instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Antimuon changes for:
https://github.com/brave/brave/issues/42