Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(uplift to 1.33.x) Signing messages with Trezor accounts (#10903) #11036

Merged
merged 1 commit into from
Nov 12, 2021
Merged

(uplift to 1.33.x) Signing messages with Trezor accounts (#10903) #11036

merged 1 commit into from
Nov 12, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Nov 12, 2021 •
edited
Loading

Uplift of #10903
Resolves brave/brave-browser#19219

SHOULD BE MERGED AFTER #11026

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@spylogsster
Sign messages by Trezor (#10903)
6eeed77 
(cherry picked from commit a375958)
@spylogsster spylogsster requested a review from a team November 12, 2021 07:24
@spylogsster spylogsster requested review from a team as code owners November 12, 2021 07:24
@spylogsster spylogsster changed the title (uplift to 1.33.x) Signing messages with Trezor accounts (#10902) (uplift to 1.33.x) Signing messages with Trezor accounts (#10903) Nov 12, 2021
@spylogsster spylogsster changed the base branch from 1.33.x to pr10902_sign_trezor_transactions_to_33 November 12, 2021 15:46
@spylogsster spylogsster merged this pull request into pr10902_sign_trezor_transactions_to_33 Nov 12, 2021
@spylogsster spylogsster deleted the pr10903_sign_trezor_messages_to_33 branch November 12, 2021 15:58
spylogsster added a commit that referenced this pull request Nov 12, 2021
@spylogsster
Sign messages by Trezor (#10903) (#11036)
4901c56 
(cherry picked from commit a375958)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spylogsster spylogsster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@spylogsster