Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes wrong log message for promoted content ad when not found in the catalog #11377

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Fixes wrong log message for promoted content ad when not found in the catalog #11377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...-ads/src/bat/ads/internal/database/tables/creative_promoted_content_ads_database_table.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ void CreativePromotedContentAds::OnGetForCreativeInstanceId(
GetCreativePromotedContentAdCallback callback) {
if (!response ||
response->status != mojom::DBCommandResponse::Status::RESPONSE_OK) {
BLOG(0, "Failed to get creative new tab page ad");
BLOG(0, "Failed to get creative promoted content ad");
callback(/* success */ false, creative_instance_id, {});
return;
}
Expand All @@ -524,7 +524,7 @@ void CreativePromotedContentAds::OnGetForCreativeInstanceId(
GetCreativeAdsFromResponse(std::move(response));

if (creative_ads.size() != 1) {
BLOG(0, "Failed to get creative new tab page ad");
BLOG(0, "Failed to get creative promoted content ad");
callback(/* success */ false, creative_instance_id, {});
return;
}
Expand All @@ -540,7 +540,7 @@ void CreativePromotedContentAds::OnGetForSegments(
GetCreativePromotedContentAdsCallback callback) {
if (!response ||
response->status != mojom::DBCommandResponse::Status::RESPONSE_OK) {
BLOG(0, "Failed to get creative new tab page ads");
BLOG(0, "Failed to get creative promoted content ads");
callback(/* success */ false, segments, {});
return;
}
Expand Down