-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Tab Page WebUI - remove widget visibility migration #11847
Conversation
A Storybook has been deployed to preview UI for the latest push |
@petemill I just added the |
…nitial pref value to false This should have no effect since all (or most) existing users would be migrated with the last 2 major releases and now only new users would be affected
01a4fa9
to
67a9388
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
A Storybook has been deployed to preview UI for the latest push |
…tion New Tab Page WebUI - remove widget visibility migration
…tion New Tab Page WebUI - remove widget visibility migration
Verification PASSED on
Verified the STR/Cases outlined via brave/brave-browser#20501 (comment) and ensured that there wasn't any outbound network connections when opening the NTP on a new profile. Example: Also ensured that none of the crypto widgets were visible on a new profile but were available via the following:
For the following cases, upgrade from
|
…tion-1-35-x 1.35 - Uplift pull request #11847 from brave/ntp-widget-done-visibility-migration
…tion-1-34-x 1.34.x - Uplift pull request #11847 from brave/ntp-widget-done-visibility-migration
Resolves brave/brave-browser#20501
The migration was also checking for whether the user had previously connected to a widget by requesting data, instead of checking the token.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: