Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tab Page WebUI - remove widget visibility migration #11847

Merged
merged 1 commit into from
Jan 15, 2022

Conversation

petemill
Copy link
Member

Resolves brave/brave-browser#20501

The migration was also checking for whether the user had previously connected to a widget by requesting data, instead of checking the token.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@petemill petemill self-assigned this Jan 14, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 14, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@wknapik wknapik added the CI/run-network-audit Run network-audit label Jan 14, 2022
@wknapik
Copy link
Collaborator

wknapik commented Jan 14, 2022

@petemill I just added the CI/run-network-audit label. You might want to rebuild.

…nitial pref value to false

This should have no effect since all (or most) existing users would be migrated with the last 2 major releases and now only new users would be affected
@petemill petemill force-pushed the ntp-widget-done-visibility-migration branch from 01a4fa9 to 67a9388 Compare January 15, 2022 00:45
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@petemill petemill merged commit 7c368e2 into master Jan 15, 2022
@petemill petemill deleted the ntp-widget-done-visibility-migration branch January 15, 2022 06:01
@petemill petemill added this to the 1.36.x - Nightly milestone Jan 15, 2022
petemill added a commit that referenced this pull request Jan 15, 2022
…tion

New Tab Page WebUI - remove widget visibility migration
petemill added a commit that referenced this pull request Jan 15, 2022
…tion

New Tab Page WebUI - remove widget visibility migration
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build:

Brave | 1.36.48 Chromium: 97.0.4692.71 (Official Build) nightly (64-bit)
-- | --
Revision | adefa7837d02a07a604c1e6eff0b3a09422ab88d-refs/branch-heads/4692@{#1247}
OS | Windows 11 Version 21H2 (Build 22000.434)

Clean Install Cases

Verified the STR/Cases outlined via brave/brave-browser#20501 (comment) and ensured that there wasn't any outbound network connections when opening the NTP on a new profile. Example:

startupNetworkCalls

Also ensured that none of the crypto widgets were visible on a new profile but were available via the following:

  • Customise dashboard -> Cards

Upgrade Cases

For the following cases, upgrade from 1.36.47 Chromium: 97.0.4692.71 --> 1.36.48 Chromium: 97.0.4692.71

  • ensured that crypto widgets are being displayed in the widget stack if a user has already enabled them
    • checked using Binance, FTX & Gemini
  • ensured that users stay authenticated after upgrading when the widget is active/visible under the widget stack
  • ensured that users stay authenticated after upgrading when the authenticated widget isn't active/visible in the widget stack
  • ensured that the correct order/active widget is maintained after upgrading
  • ensured that crypto widgets are not being removed from the widget stack and into Customise dashboard -> Cards when they've been enabled

kjozwiak added a commit that referenced this pull request Jan 20, 2022
…tion-1-35-x

1.35 - Uplift pull request #11847 from brave/ntp-widget-done-visibility-migration
kjozwiak added a commit that referenced this pull request Jan 20, 2022
…tion-1-34-x

1.34.x - Uplift pull request #11847 from brave/ntp-widget-done-visibility-migration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTX widget causing requests to ftx.com at startup without user opt-in
6 participants