Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 97.0.4692.71 to Chromium 97.0.4692.99 (uplift to 1.35.x). #11915

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#20553
Uplift from #11910

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Upgrade from Chromium 97.0.4692.71 to Chromium 97.0.4692.99
@mkarolin mkarolin added the CI/run-network-audit Run network-audit label Jan 20, 2022
@mkarolin mkarolin requested a review from a team January 20, 2022 04:31
@mkarolin mkarolin requested a review from a team as a code owner January 20, 2022 04:31
@mkarolin mkarolin self-assigned this Jan 20, 2022
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Jan 20, 2022
@kjozwiak
Copy link
Member

Restarting Linux due to the node failing to start as per https://ci.brave.com/job/pr-brave-browser-97.0.4692.99_master-1.35.x-linux/1/consoleFull#-1404553934c752f54c-6ec7-41c5-bda6-117c29803898:

 hudson.remoting.ProxyException: Assertion failed: 
23:38:29  
23:38:29  assert(nodeId?.trim())
23:38:29  
23:38:29  	at org.codehaus.groovy.runtime.InvokerHelper.assertFailed(InvokerHelper.java:420)
23:38:29  	at org.codehaus.groovy.runtime.ScriptBytecodeAdapter.assertFailed(ScriptBytecodeAdapter.java:663)
23:38:29  	at com.cloudbees.groovy.cps.impl.AssertBlock$ContinuationImpl.fail(AssertBlock.java:47)
23:38:29  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
23:38:29  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
23:38:29  	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
23:38:29  	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
23:38:29  	at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72)
23:38:29  	at com.cloudbees.groovy.cps.impl.ConstantBlock.eval(ConstantBlock.java:21)
23:38:29  	at com.cloudbees.groovy.cps.Next.step(Next.java:83)
23:38:29  	at com.cloudbees.groovy.cps.Continuable$1.call(Continuable.java:174)
23:38:29  	at com.cloudbees.groovy.cps.Continuable$1.call(Continuable.java:163)
23:38:29  	at org.codehaus.groovy.runtime.GroovyCategorySupport$ThreadCategoryInfo.use(GroovyCategorySupport.java:136)
23:38:29  	at org.codehaus.groovy.runtime.GroovyCategorySupport.use(GroovyCategorySupport.java:275)
23:38:29  	at com.cloudbees.groovy.cps.Continuable.run0(Continuable.java:163)
23:38:29  	at org.jenkinsci.plugins.workflow.cps.SandboxContinuable.access$001(SandboxContinuable.java:18)
23:38:29  	at org.jenkinsci.plugins.workflow.cps.SandboxContinuable.run0(SandboxContinuable.java:51)
23:38:29  	at org.jenkinsci.plugins.workflow.cps.CpsThread.runNextChunk(CpsThread.java:185)
23:38:29  	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:402)
23:38:29  	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$400(CpsThreadGroup.java:96)
23:38:29  	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:314)
23:38:29  	at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:278)
23:38:29  	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:67)
23:38:29  	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
23:38:29  	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:139)
23:38:29  	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
23:38:29  	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:68)
23:38:29  	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
23:38:29  	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
23:38:29  	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
23:38:29  	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
23:38:29  	at java.base/java.lang.Thread.run(Thread.java:834)
23:38:29  Finished: FAILUR

@kjozwiak kjozwiak added this to the 1.35.x - Beta milestone Jan 20, 2022
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.35.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit f5c1f70 into 1.35.x Jan 20, 2022
@kjozwiak kjozwiak deleted the 97.0.4692.99_master-1.35.x branch January 20, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants