Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Time-limited sync words #12300

Merged
merged 11 commits into from
May 26, 2022
Merged

Time-limited sync words #12300

merged 11 commits into from
May 26, 2022

Commits on May 25, 2022

  1. Removed forgotten include

    @AlexeyBarabash
    AlexeyBarabash committed May 25, 2022
    Configuration menu
    Copy the full SHA
    8f1e1d4 View commit details
    Browse the repository at this point in the history

  2. Time-limited sync words class and tests 

    Fixes brave/brave-browser#22242
    @AlexeyBarabash
    AlexeyBarabash committed May 25, 2022
    Configuration menu
    Copy the full SHA
    9fe2d6d View commit details
    Browse the repository at this point in the history

  3. Desktop uses sync words v2

    @AlexeyBarabash
    AlexeyBarabash committed May 25, 2022
    Configuration menu
    Copy the full SHA
    544947a View commit details
    Browse the repository at this point in the history

  4. Desktop setup sync error messages

    @AlexeyBarabash
    AlexeyBarabash committed May 25, 2022
    Configuration menu
    Copy the full SHA
    7aab3d0 View commit details
    Browse the repository at this point in the history

  5. Android connects to sync through time limited bip words

    @AlexeyBarabash
    AlexeyBarabash committed May 25, 2022
    Configuration menu
    Copy the full SHA
    00c7598 View commit details
    Browse the repository at this point in the history

  6. Brave sync settings page getPureSyncCode method to receive sync words… 

    … without 25th word of time code
    @AlexeyBarabash
    AlexeyBarabash committed May 25, 2022
    Configuration menu
    Copy the full SHA
    b2ee995 View commit details
    Browse the repository at this point in the history

  7. Fixed sync QR code generation to use pure sync words

    @AlexeyBarabash
    AlexeyBarabash committed May 25, 2022
    Configuration menu
    Copy the full SHA
    a35d312 View commit details
    Browse the repository at this point in the history

  8. Adjusted kWordsv1SunsetDate date

    @AlexeyBarabash
    AlexeyBarabash committed May 25, 2022
    Configuration menu
    Copy the full SHA
    f0092bb View commit details
    Browse the repository at this point in the history

  9. Desktop sync setup shows different error messages

    @AlexeyBarabash
    AlexeyBarabash committed May 25, 2022
    Configuration menu
    Copy the full SHA
    6726848 View commit details
    Browse the repository at this point in the history

  10. Introduced TimeLimitedWords::GetWordsV2Epoch() date

    @AlexeyBarabash
    AlexeyBarabash committed May 25, 2022
    Configuration menu
    Copy the full SHA
    c57800d View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. Addressed codereview suggestions: 

    - updated comments
- removed forgotten include
- used base::StrCat
- redone TimeLimitedWords::Validate => TimeLimitedWords::Parse to avoid using of output string* parameter
- fixed ret.pure_words initialization
- removed forgotten log
- from js and html changes combined variables isInvalidSyncCode and syncCodeValidationResult into single syncCodeValidationError

Adjusted words epoch and v1 sunset dates
- epoch to Tue, 10 May 2022
- sunset to Mon, 1 Aug 2022
    @AlexeyBarabash
    AlexeyBarabash committed May 26, 2022
    Configuration menu
    Copy the full SHA
    a66b2d5 View commit details
    Browse the repository at this point in the history