Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Always show full URLs sentence casing #13612

Closed
wants to merge 1 commit into from

Conversation

Tonev
Copy link
Contributor

@Tonev Tonev commented Jun 4, 2022

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@@ -5937,7 +5937,7 @@ Keep your key file in a safe place. You will need it to create new versions of y
</message>
<if expr="use_titlecase">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is quite the right fix, as this string is meant to be used when use_titlecase is in effect (for instance, I think in Mac menu items). Instead, I think this string should remain as-is and we'll need to break out the settings item into its own string that doesn't use title case at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I wasn't sure about it either. Thought I could give it a try after discussing the matter with Stephen (brave/brave-browser#16939 (comment)), but it's all right if you decide to close this one as I'm not aware how to resolve this issue if the change I proposed is wrong. I'm really interested to see how it's fixed properly 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Your proposed fix was my first thought too; I just happened to notice the use_titlecase directive above it.

@Tonev
Copy link
Contributor Author

Tonev commented Jun 11, 2022

I'll be closing this pull request as proposed changes aren't enough to resolve the issue.

@Tonev Tonev closed this Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants