Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated colors that used in theme_properties to color provider pipeline (uplift to 1.41.x) #13865

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Migrated colors that used in theme_properties to color provider pipeline (uplift to 1.41.x) #13865

merged 1 commit into from
Jun 23, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jun 20, 2022 •
edited by kjozwiak
Loading

Uplift of #13841
fix brave/brave-browser#23423

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested review from simonhong and a team as code owners June 20, 2022 04:35
@brave-builds brave-builds requested a review from a team June 20, 2022 04:35
@brave-builds brave-builds self-assigned this Jun 20, 2022
@brave-builds brave-builds added this to the 1.41.x - Beta milestone Jun 20, 2022
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Jun 20, 2022
@simonhong simonhong self-assigned this Jun 20, 2022
kjozwiak
kjozwiak approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.41.x approved 👍 QA has verified the PR on Nightly as per #13841 (comment).

@kjozwiak kjozwiak merged commit 2e9efa3 into 1.41.x Jun 23, 2022
@kjozwiak kjozwiak deleted the pr13841_new_tab_button_bg_color_1.41.x branch June 23, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@simonhong simonhong Awaiting requested review from simonhong

Assignees

@simonhong simonhong

@brave-builds brave-builds

Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.41.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @simonhong @brave-browser-releases