Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix confirmations link failure windows #1468

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Jan 26, 2019

Fixes brave/brave-browser#3114

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@emerick emerick self-assigned this Jan 26, 2019
@emerick emerick requested a review from tmancey January 26, 2019 03:07
@emerick emerick added this to the 0.62.x - Nightly milestone Jan 26, 2019
@emerick emerick changed the base branch from master to issues/2912-0.61.x January 26, 2019 03:08
@tmancey tmancey closed this Jan 26, 2019
@tmancey tmancey reopened this Jan 26, 2019
@tmancey tmancey merged this pull request into issues/2912-0.61.x Jan 26, 2019
@tmancey tmancey deleted the fix-confirmations-link-failure-windows branch January 26, 2019 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants