Add Brave WebUI about:payments and brave-extension loading #15

bbondy · 2017-12-30T20:05:52Z

Fix brave/brave-browser-snap#5
Fix https://github.com/brave/brave/issues/45

Requires https://github.com/brave/brave/pull/46

bridiver · 2018-01-02T03:34:39Z

patches/chrome-browser-extensions-component_loader.cc.patch

+ std::string ComponentLoader::Add(int manifest_resource_id,
+                                  const base::FilePath& root_directory) {
+   if (!ignore_whitelist_for_testing_ &&
+-      !IsComponentExtensionWhitelisted(manifest_resource_id))


wouldn't it be easier to patch IsComponentExtensionWhitelisted instead of changing all the calls to it? If new calls to IsComponentExtensionWhitelisted show up in the code they might also get missed

OK that sounds good.

bridiver · 2018-01-02T05:19:16Z

common/resource_bundle_helper.cc

+  return base::mac::PathForFrameworkBundleResource(
+      CFSTR("brave_resources.pak"));
+#else
+  base::FilePath extensions_shell_and_test_pak_path;


extensions_shell_and_test_pak_path?

Fixed, the function was copied / modified from somewhere else.

bridiver · 2018-01-02T05:24:06Z

browser/brave_browser_process_impl.cc

@@ -50,3 +51,10 @@ BraveBrowserProcessImpl::https_everywhere_service() {
    brave_shields::HTTPSEverywhereServiceFactory();
  return https_everywhere_service_.get();
 }
+
+void BraveBrowserProcessImpl::PreMainMessageLoopRun() {


we can override CreateBrowserMainParts in BraveContentBrowserClient and add our own Parts* classes with AddParts

bridiver · 2018-01-02T05:27:06Z

browser/resources/brave_extension.grd

+  </outputs>
+  <release seq="1">
+    <includes>
+      <include name="IDR_BRAVE_EXTENSON_INJECT_HTML" file="build/inject.html" type="BINDATA" />


these files seem like they're missing?

they're from src/brave/vendor/brave-extension
You'll need to run yarn install && yarn build to get them from within that dir.
There's a PR on brave/brave which has build config for that.

bridiver · 2018-01-02T05:29:57Z

common/url_constants.cc

@@ -0,0 +1,4 @@
+#include "brave/common/url_constants.h"


should this be webui_url_constants like in chrome?

It's not webui_url_constants in chrome, it's chrome/common/url_constants.h

I see, I was looking at 64, but might as well do the same now?

do this in a follow up as well?

I did this when I landed it.

bridiver · 2018-01-03T14:55:38Z

browser/ui/webui/basic_ui.cc

+      content::WebUIDataSource::Create(kPaymentsHost);
+
+  if (name == kPaymentsHost) {
+    source->AddResourcePath(kPaymentsJS, IDR_BRAVE_PAYMENTS_JS);


I was thinking we could pass these in as params in brave_web_ui_controller_factory.h

Will do this in the new tab page PR once I work on that.

bridiver · 2018-01-03T16:23:35Z

patches/chrome-browser-extensions-component_extensions_whitelist-whitelist.cc.patch

+     extension_misc::kZIPUnpackerExtensionId,
+     extension_misc::kZipArchiverExtensionId,
+ #endif
+     "mnojpmjdmbbfmejpflffifhffcmidifd"


I was thinking we would patch in a method call to add as may as we wanted, but we can do that in a follow up

Will do this once we need to add a second one.

bridiver · 2018-01-03T16:23:42Z

patches/chrome-browser-extensions-component_extensions_whitelist-whitelist.cc.patch

+   switch (manifest_resource_id) {
+     // Please keep the list in alphabetical order.
+     case IDR_BOOKMARKS_MANIFEST:
+    case IDR_BRAVE_EXTENSON:


same as above

ditto my above comment.

…sources Fix brave/brave-browser-snap#5

Which includes: - Using chrome white list directly instead of replacing the file. - Created a browser extra parts subclass and register it, it is used for resource loading init for the browser process. - Fix linux build

bridiver · 2018-01-05T22:13:03Z

browser/resources/BUILD.gn

+    "//brave/vendor/brave-extension",
+  ]
+
+  output_dir = "$root_gen_dir/brave"


I think you want to use target_gen_dir here instead of root_gen_dir/brave

bbondy · 2018-01-06T19:35:02Z

script moved to brave-extensions and renamed to webui_url_constants.*, so landing.

remove chromium_env

3rd party fingerprinting protection

Update adblock dep to latest

bbondy force-pushed the web-ui branch from 25d9745 to adbf66e Compare December 30, 2017 20:16

bbondy changed the title ~~WIP: Web ui~~ Add Brave WebUI handling and about:payments placeholder Dec 31, 2017

bbondy force-pushed the web-ui branch 5 times, most recently from 7756c23 to b6dce28 Compare December 31, 2017 04:33

bbondy requested a review from bridiver December 31, 2017 04:34

bbondy changed the title ~~Add Brave WebUI handling and about:payments placeholder~~ Add Brave WebUI about:payments and extension loading Jan 1, 2018

bbondy added the pr/work-in-progress label Jan 1, 2018

bbondy force-pushed the web-ui branch from 426fb19 to fcd7938 Compare January 1, 2018 15:11

bbondy changed the title ~~Add Brave WebUI about:payments and extension loading~~ Add Brave WebUI about:payments and brave-extension loading Jan 1, 2018

bbondy removed the pr/work-in-progress label Jan 1, 2018

bbondy force-pushed the web-ui branch from 33e8d10 to 6fb671b Compare January 1, 2018 21:56

bbondy mentioned this pull request Jan 2, 2018

Build extension on init brave/brave-browser#46

Closed

bridiver reviewed Jan 2, 2018

View reviewed changes

bbondy force-pushed the web-ui branch 2 times, most recently from 59a722b to c175206 Compare January 3, 2018 14:17

bridiver reviewed Jan 3, 2018

View reviewed changes

bbondy added 5 commits January 3, 2018 14:17

Create a subclass for creating webuis

a0d08f9

Setup to support chrome://payments

a565208

Add about:payments and basic web ui handler

a8409b6

Repack and add pak to resource bundle

f3216a9

Update extension ref

fd0d2fe

bbondy added 8 commits January 3, 2018 14:17

Subclass ComponentLoader and use Brave whitelist

258d5c5

Add brave extension resources grit

902e081

Subclass ChromeComponentExtensionResourceManager to find extension re…

167aaff

…sources Fix brave/brave-browser-snap#5

Implement review comments

c175206

Which includes: - Using chrome white list directly instead of replacing the file. - Created a browser extra parts subclass and register it, it is used for resource loading init for the browser process. - Fix linux build

Update extension

5bf9ffd

Use DEPS hook and gn for extension init

d39abb0

Fix resource loading on Windows

0220231

Make sure extension generated files are created sync

f10b503

bridiver reviewed Jan 5, 2018

View reviewed changes

bbondy force-pushed the web-ui branch 2 times, most recently from ae48d15 to f937a93 Compare January 6, 2018 17:39

Move brave-extension script to brave/brave-extension

2d57a19

bbondy force-pushed the web-ui branch from f937a93 to 2d57a19 Compare January 6, 2018 17:51

Rename url_constants.* to webui_url_constants

3429d5e

bbondy force-pushed the web-ui branch from b88079c to 3429d5e Compare January 6, 2018 19:33

bbondy merged commit 46ea972 into master Jan 6, 2018

NejcZdovc pushed a commit that referenced this pull request Dec 10, 2018

Merge pull request #15 from brave-intl/chromium-env

51de734

remove chromium_env

bbondy pushed a commit that referenced this pull request Feb 18, 2019

Merge pull request #15 from brave/3rd_party_FP

6b9e384

3rd party fingerprinting protection

btlechowski mentioned this pull request Jan 6, 2021

Match redirect chain URLs against Brave Ad conversion URL patterns #7330

Merged

23 tasks

antonok-edm pushed a commit that referenced this pull request Mar 10, 2021

Merge pull request #15 from brave/adblock-bump

8e45290

Update adblock dep to latest

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Brave WebUI about:payments and brave-extension loading #15

Add Brave WebUI about:payments and brave-extension loading #15

bbondy commented Dec 30, 2017 •

edited

Loading

bridiver Jan 2, 2018

bbondy Jan 2, 2018

bridiver Jan 2, 2018

bbondy Jan 2, 2018

bridiver Jan 2, 2018 •

edited

Loading

bridiver Jan 2, 2018

bbondy Jan 2, 2018

bridiver Jan 2, 2018

bbondy Jan 2, 2018 •

edited

Loading

bridiver Jan 3, 2018

bridiver Jan 5, 2018

bbondy Jan 7, 2018

bridiver Jan 3, 2018

bbondy Jan 3, 2018

bridiver Jan 3, 2018

bbondy Jan 3, 2018

bridiver Jan 3, 2018

bbondy Jan 3, 2018

bridiver Jan 5, 2018

bbondy commented Jan 6, 2018

Add Brave WebUI about:payments and brave-extension loading #15

Add Brave WebUI about:payments and brave-extension loading #15

Conversation

bbondy commented Dec 30, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bridiver Jan 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bbondy Jan 2, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bbondy commented Jan 6, 2018

bbondy commented Dec 30, 2017 •

edited

Loading

bridiver Jan 2, 2018 •

edited

Loading

bbondy Jan 2, 2018 •

edited

Loading