Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add packages and libraries to filter list for dep checking on linux #150

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Add packages and libraries to filter list for dep checking on linux #150

merged 1 commit into from
Jun 7, 2018

Conversation

bkero
Copy link
Contributor

@bkero bkero commented Jun 7, 2018

This commit is in reference to brave/brave-browser#305

We still need to run the update script by hand though, to generate a
useful json file.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Run a linux build with these patches applied.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@bkero
Add packages and libraries to filter list for dep checking on linux
af4f48e 
This commit is in reference to brave/brave-browser#305

We still need to run the update script by hand though, to generate a
useful json file.
@bkero bkero merged commit 86d4d17 into brave:master Jun 7, 2018
@bkero bkero deleted the update-package-filter branch June 7, 2018 19:45
bridiver
bridiver reviewed Jun 7, 2018
View reviewed changes
patches/chrome-installer-linux-rpm-update_package_provides.py.patch
"libnssutil3.so",
"libpango-1.0.so",
"libpangocairo-1.0.so",
+ "libplc4.so",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these from?

bridiver
bridiver reviewed Jun 7, 2018
View reviewed changes
patches/chrome-installer-linux-rpm-update_package_provides.py.patch
+ "libplc4.so",
+ "libplds4.so",
"libpthread.so",
+ "libresolv.so.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are both from https://staging.ci.brave.com/job/brave-browser-build-linux/28/console
(The same is reflected in the linked issue)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

must be deps of the new deps. Ok

bridiver
bridiver reviewed Jun 7, 2018
View reviewed changes
patches/chrome-installer-linux-debian-update_dist_package_versions.py.patch
"libatk-bridge2.0-0",
"libc6",
"libcairo2",
+ "libcairo-gobject2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll be less likely to run into conflicts if we put these at the top of the list instead of keeping the alphabetical order - same with the other file

NejcZdovc added a commit that referenced this pull request Dec 10, 2018
@NejcZdovc
Merge pull request #150 from brave-intl/upgrade-path
3e35b5e 
Adds upgrade path from 55.12-55.14
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Add CLI arg for starting without Brave extension
b5cfe50 
Fix #150

Related: #87

You can do this with:

```
npm run start -- --disable_brave_extension
```

or

```
yarn start --disable_brave_extension
```
petemill pushed a commit that referenced this pull request Jul 27, 2020
@bbondy
Add CLI arg for starting without Brave extension
08737c2 
Fix #150

Related: #87

You can do this with:

```
npm run start -- --disable_brave_extension
```

or

```
yarn start --disable_brave_extension
```
petemill pushed a commit that referenced this pull request Jul 28, 2020
@bbondy
Add CLI arg for starting without Brave extension
b496a3b 
Fix #150

Related: #87

You can do this with:

```
npm run start -- --disable_brave_extension
```

or

```
yarn start --disable_brave_extension
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver left review comments

@mbacchi mbacchi mbacchi approved these changes

@RyanJarv RyanJarv Awaiting requested review from RyanJarv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkero @bridiver @mbacchi