Fixes wallet bad state #1508
Merged
Fixes wallet bad state #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
resolve-bad-state
branch
3 times, most recently
from
bc995d1
to
49b0220
Compare
NejcZdovc
commented
Jan 30, 2019
| @@ -32,9 +32,10 @@ export const defaultState: Rewards.State = { | |||
| recoveryKey: '', | |||
| reconcileStamp: 0, | |||
| ui: { | |||
| addressCheck: false, | |||
| addressCheck: true, | |||
There was a problem hiding this comment.
changed this as we don't need to run legacy fix for new installs
NejcZdovc
force-pushed
the
resolve-bad-state
branch
2 times, most recently
from
f78bd1d
to
1cc6398
Compare
|
Can you clarify step 15 of the test plan? The addresses in my ledger_state are the same as the ones I changed them to. |
|
@jasonrsadler so when you start your browser in step 15 and then close it you have addresses in |
|
Step 7 |
NejcZdovc
force-pushed
the
resolve-bad-state
branch
2 times, most recently
from
ca796fa
to
8e6f1cc
Compare
NejcZdovc
force-pushed
the
resolve-bad-state
branch
3 times, most recently
from
aefb3e1
to
37fd885
Compare
NejcZdovc
commented
Feb 4, 2019
| } | ||
| state = saveAddresses(state, action.payload.addresses) | ||
| let ui = state.ui | ||
| ui.addressCheck = true |
There was a problem hiding this comment.
moved to final step as before it was in init call
NejcZdovc
force-pushed
the
resolve-bad-state
branch
from
37fd885
to
c9c7175
Compare
jasonrsadler
previously requested changes
Feb 4, 2019
Resolves brave/brave-browser#3061 Resolves brave/brave-browser#3060
NejcZdovc
force-pushed
the
resolve-bad-state
branch
from
c9c7175
to
02920c4
Compare
jasonrsadler
approved these changes
Feb 4, 2019
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#3061
Resolves brave/brave-browser#3060
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
OIeFXZsZd5rHDzAMwN1I0F1AX4S9KPM78uNTvmJZak8=decade destroy first curtain number sniff bring toward art alone fall pass staff cool base pink veteran test rhythm polar tower coach powder waveReviewer Checklist: