Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix few more ASAN issues in tests. #15130

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Fix few more ASAN issues in tests. #15130

merged 1 commit into from
Sep 20, 2022

Conversation

goodov
Copy link
Member

@goodov goodov commented Sep 19, 2022

Resolves https://github.com/brave/internal/issues/912

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov requested a review from yrliou September 19, 2022 10:29
@goodov goodov requested a review from a team as a code owner September 19, 2022 10:29
@goodov goodov merged commit 5ddf131 into master Sep 20, 2022
@goodov goodov deleted the issues/912 branch September 20, 2022 07:27
@github-actions github-actions bot added this to the 1.45.x - Nightly milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants