Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for crash reporting on Linux. #1521

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#1251
Uplift request from #1480

- Patches ChromeCrashReporterClient::GetCollectStatsConsent to check for
  BRAVE_CHROMIUM_BUILD in addition to GOOGLE_CHROME_BUILD.
- Patches breakpad Linux implementation with Brave's crash reporting upload
  endpoint.

Fixes brave/brave-browser#1251
@mkarolin mkarolin added this to the 0.60.x - Beta milestone Jan 30, 2019
@mkarolin mkarolin self-assigned this Jan 30, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Deliberated with @kjozwiak, approved for 60.x

@mkarolin mkarolin merged commit a2d07fc into 0.60.x Jan 31, 2019
@mkarolin mkarolin deleted the maxk-linux-crash-reporting-0.60.x branch January 31, 2019 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants