Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android 13] Notifications - user manually disable notifications (uplift to 1.46.x) #15951

Merged
merged 6 commits into from
Nov 23, 2022
Merged

[Android 13] Notifications - user manually disable notifications (uplift to 1.46.x) #15951

merged 6 commits into from
Nov 23, 2022

Conversation

sujitacharya2005
Copy link
Contributor

Uplift of #15407
Resolves brave/brave-browser#25042

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@sujitacharya2005 sujitacharya2005 added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Nov 15, 2022
@sujitacharya2005 sujitacharya2005 added this to the 1.46.x - Beta milestone Nov 15, 2022
@sujitacharya2005 sujitacharya2005 self-assigned this Nov 15, 2022
@sujitacharya2005 sujitacharya2005 requested a review from a team as a code owner November 15, 2022 17:44
@sujitacharya2005 sujitacharya2005 force-pushed the 25042_android_13_privacy_rewards_1.46.x branch 7 times, most recently from 79a8ccf to ccdbb5e Compare November 22, 2022 19:35
@sujitacharya2005 sujitacharya2005 force-pushed the 25042_android_13_privacy_rewards_1.46.x branch from ccdbb5e to 3c42158 Compare November 23, 2022 07:07
srirambv
srirambv approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.46.x is approved on behalf of @brave/uplift-approvers. QA verified the PR on nightly as per #15407 (comment)

@srirambv srirambv merged commit 1d11e41 into 1.46.x Nov 23, 2022
@srirambv srirambv deleted the 25042_android_13_privacy_rewards_1.46.x branch November 23, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srirambv srirambv srirambv approved these changes

Assignees

@sujitacharya2005 sujitacharya2005

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@sujitacharya2005 @srirambv