-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] remove old widgets on upgrade scenario #16744
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing new line at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was missing in the master. I have added in the commit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
import org.chromium.chrome.browser.quickactionsearchwidget.QuickActionSearchWidgetProvider; | ||
|
||
public abstract class BraveQuickActionSearchWidgetProvider extends QuickActionSearchWidgetProvider { | ||
public static void setWidgetEnabled( | ||
boolean shouldEnableQuickActionSearchWidget, boolean shouldEnableDinoVariant) { | ||
// We don't need to do anything here as in QuickActionSearchWidgetProvider we only set dino | ||
// and quick search widgets. | ||
setWidgetComponentEnabled(QuickActionSearchWidgetProviderSearch.class, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems we need to remove widgets explicitly. good find.
Verified on
Upgraded Profile
Fresh Profile
|
Resolves brave/brave-browser#27757
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: