Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up pre-populated search engines. (uplift to 0.60.x) #1676

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

mkarolin
Copy link
Collaborator

Engines kept:
- Google
- Duckduckgo
- Qwant
- Bing
- Startpage.

Adds a unit test to verify the search engines overridden by us are used
instead of the original ones.

Lint fixes.

Fixes brave/brave-browser#3316
@mkarolin mkarolin added this to the 0.60.x - Beta milestone Feb 14, 2019
@mkarolin mkarolin self-assigned this Feb 14, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 4fdd03d into 0.60.x Feb 14, 2019
@bsclifton bsclifton deleted the maxk-cleanup-prepopulated-search-engines-0.60.x branch February 14, 2019 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants