Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet) Add NFT Pinning #16998

Merged
merged 5 commits into from
Feb 10, 2023
Merged

feat(wallet) Add NFT Pinning #16998

merged 5 commits into from
Feb 10, 2023

Conversation

muliswilliam
Copy link
Contributor

@muliswilliam muliswilliam commented Feb 2, 2023 •
edited
Loading

Resolves brave/brave-browser#26828

Sec review : https://github.com/brave/security/issues/1182

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

1. First Time NFT Pinning Flow:

NFT.Pinning.for.existing.tokens-1.mov

2. NFT Pinning for a newly added token

Pinning.new.token.mov

@muliswilliam muliswilliam requested review from a team as code owners February 2, 2023 15:00
@yrliou
Copy link
Member

yrliou commented Feb 2, 2023

@muliswilliam @cypt4 just a friendly note that nothing should be accessible/triggered without enabling the feature flag, and please open a security & privacy issue to prepare for enabling the feature flag linking to this PR and the core PR, thanks.

github-actions[bot]
github-actions bot reviewed Feb 3, 2023
View reviewed changes
components/brave_wallet_ui/assets/svg-icons/nft-ipfs/nfts-illustration.svg Outdated Show resolved Hide resolved
components/brave_wallet_ui/assets/svg-icons/nft-ipfs/nfts-illustration.svg Outdated Show resolved Hide resolved
components/brave_wallet_ui/assets/svg-icons/nft-ipfs/nfts-illustration.svg Outdated Show resolved Hide resolved
components/brave_wallet_ui/assets/svg-icons/nft-ipfs/nfts-illustration.svg Outdated Show resolved Hide resolved
components/brave_wallet_ui/assets/svg-icons/nft-ipfs/nfts-illustration.svg Outdated Show resolved Hide resolved
components/brave_wallet_ui/assets/svg-icons/nft-ipfs/nfts-illustration.svg Outdated Show resolved Hide resolved
components/brave_wallet_ui/assets/svg-icons/nft-ipfs/nfts-illustration.svg Outdated Show resolved Hide resolved
components/brave_wallet_ui/assets/svg-icons/nft-ipfs/nfts-illustration.svg Outdated Show resolved Hide resolved
components/brave_wallet_ui/assets/svg-icons/nft-ipfs/nfts-illustration.svg Outdated Show resolved Hide resolved
components/brave_wallet_ui/assets/svg-icons/nft-ipfs/nfts-illustration.svg Outdated Show resolved Hide resolved
Douglashdaniel
Douglashdaniel requested changes Feb 6, 2023
View reviewed changes
components/brave_wallet_ui/common/hooks/nft-pin.ts
Comment on lines +30 to +33
const userVisibleTokensInfo = useUnsafeWalletSelector(
WalletSelectors.userVisibleTokensInfo
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this down under the // redux comment?

components/brave_wallet_ui/common/hooks/nft-pin.ts Show resolved Hide resolved
components/brave_wallet_ui/common/hooks/nft-pin.ts Outdated Show resolved Hide resolved
components/brave_wallet_ui/common/hooks/nft-pin.ts

return BraveWallet.TokenPinStatusCode.STATUS_NOT_PINNED
}, [nftsPinningStatus, pinnableNfts.length, pinnedNftsCount])

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a // methods comment here?

components/brave_wallet_ui/common/hooks/nft-pin.ts Outdated Show resolved Hide resolved
components/brave_wallet_ui/components/desktop/views/nfts/nft-view.tsx Outdated Show resolved Hide resolved
..._ui/components/desktop/views/portfolio/components/ipfs-node-status/ipfs-node-status.style.ts Outdated Show resolved Hide resolved
...allet_ui/components/desktop/views/portfolio/components/ipfs-node-status/ipfs-node-status.tsx Outdated Show resolved Hide resolved
components/brave_wallet_ui/components/shared/nft-icon/nft-icon-with-network-icon.tsx Outdated Show resolved Hide resolved
components/brave_wallet_ui/nft/components/nft-details/nft-details-styles.ts Outdated Show resolved Hide resolved
@thypon thypon unassigned fmarier and thypon Feb 7, 2023
@muliswilliam muliswilliam force-pushed the feat-nft-pinning-frontend-integration branch from a2929e4 to 5853915 Compare February 8, 2023 07:32
@thypon thypon unassigned fmarier and thypon Feb 8, 2023
Douglashdaniel
Douglashdaniel approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Nice work! 🔥

cypt4
cypt4 approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@cypt4 cypt4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...nts/brave_wallet_ui/components/desktop/views/portfolio/components/token-lists/token-list.tsx
hideAccountFilter,
hideAutoDiscovery
}: Props) => {
userAssetList,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this changes?

stoletheminerals
stoletheminerals approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@stoletheminerals stoletheminerals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok to be merged since it's behind a feature flag. The review is still in process, so we shouldn't enable the feature by default

@muliswilliam muliswilliam force-pushed the feat-nft-pinning-frontend-integration branch from 3a38de0 to 4f33c10 Compare February 10, 2023 06:38
@muliswilliam muliswilliam merged commit e2a9d33 into master Feb 10, 2023
@muliswilliam muliswilliam deleted the feat-nft-pinning-frontend-integration branch February 10, 2023 09:54
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 10, 2023
@srirambv srirambv mentioned this pull request Mar 28, 2023
Closed
This was referenced Jun 7, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@stoletheminerals stoletheminerals stoletheminerals approved these changes

@Douglashdaniel Douglashdaniel Douglashdaniel approved these changes

@cypt4 cypt4 cypt4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging this pull request may close these issues.

[Desktop] Implement NFT Pinning
7 participants
@muliswilliam @yrliou @stoletheminerals @Douglashdaniel @cypt4 @fmarier @thypon