Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adblock-rust to v0.7.5 #17313

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Update adblock-rust to v0.7.5 #17313

merged 2 commits into from
Feb 22, 2023

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Feb 21, 2023

Resolves brave/brave-browser#28609

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#28609 - the promoted posts should not appear. Note that Aggressive blocking mode is required.

@antonok-edm antonok-edm requested a review from a team as a code owner February 21, 2023 21:04
@antonok-edm antonok-edm self-assigned this Feb 21, 2023
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Feb 21, 2023
@@ -5,7 +5,7 @@ authors = ["Brian R. Bondy <[email protected]>"]
edition = "2018"

[dependencies]
adblock = { version = "0.7.3", default-features = false, features = ["full-regex-handling", "debug-info", "css-validation"] }
adblock = { version = "0.7.4", default-features = false, features = ["full-regex-handling", "debug-info", "css-validation"] }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primarily brave/adblock-rust#273, along with a dependabot update for a dev-dependency and two small cleanup commits.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonok-edm antonok-edm changed the title Update adblock-rust to v0.7.4 Update adblock-rust to v0.7.5 Feb 22, 2023
@bridiver bridiver merged commit 74512f0 into master Feb 22, 2023
@bridiver bridiver deleted the adblock-rust-0.7.4 branch February 22, 2023 04:51
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the :-abp-has() procedural selector in adblock rules
2 participants