Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Use Contract Address and ChainId in Spot Prices #17367

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

Douglashdaniel
Copy link
Contributor

Description

Fixes a bug where If you add the same token for a L1 network and L2 network, if the token on the L1 network doesn't have a balance, the fiat value would show 0.00 for the token on the L2 network with a balance.

Resolves brave/brave-browser#28753

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Add a token that has a balance on a L2 chain
  2. Now add that same token on a L1 chain without a balance
  3. The L2 fiat balance should not show 0.00

Before:

Before.mov

After:

After.mov

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner February 24, 2023 21:08
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 24, 2023
@Douglashdaniel Douglashdaniel force-pushed the use-contract-address-in-spot-prices branch from 4ef0bfd to 2563fa9 Compare February 24, 2023 22:27
@Douglashdaniel Douglashdaniel changed the title fix(wallet): Use Contract Address in Spot Prices fix(wallet): Use Contract Address and ChainId in Spot Prices Feb 24, 2023
Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Douglashdaniel Douglashdaniel force-pushed the use-contract-address-in-spot-prices branch from 2563fa9 to 6546214 Compare February 24, 2023 22:57
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fiat value showing 0 when having the same tokens on different chains
3 participants