Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error message: Brave needs Windows 10, not 7/8 (uplift to 1.49.x) #17486

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Fix error message: Brave needs Windows 10, not 7/8 (uplift to 1.49.x) #17486

merged 1 commit into from
Mar 8, 2023

Conversation

mherrmann
Copy link
Collaborator

@mherrmann mherrmann commented Mar 6, 2023 •
edited by kjozwiak
Loading

Uplift of #17234
Resolves brave/brave-browser#28511

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@mherrmann mherrmann added this to the 1.49.x - Release milestone Mar 6, 2023
@mherrmann mherrmann self-assigned this Mar 6, 2023
@mherrmann mherrmann requested a review from a team as a code owner March 6, 2023 15:03
@mherrmann mherrmann force-pushed the update-win-7-8-compatibility-error-message-uplift-1.49.x branch from c662575 to b2f2c6a Compare March 6, 2023 16:24
@mherrmann
Copy link
Collaborator Author

Looking good on (German) Windows 8:

image

@mherrmann
Copy link
Collaborator Author

mherrmann commented Mar 6, 2023 •
edited
Loading

Windows 10 still works as expected:

image

@mherrmann
Copy link
Collaborator Author

(This PR can be tested by running BraveBrowserStandaloneNightlySetup.exe from https://ci.brave.com/job/test-brave-browser-build-windows-x64/806/ on Windows 7/8/10/11. The standalone binaries produced by the PR builder don't work because they are not Release builds.)

kjozwiak
kjozwiak approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.49.x approved 👍 QA has verified the PR on Nightly as per #17234 (comment).

@kjozwiak kjozwiak merged commit d6332d5 into 1.49.x Mar 8, 2023
@kjozwiak kjozwiak deleted the update-win-7-8-compatibility-error-message-uplift-1.49.x branch March 8, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@mherrmann mherrmann

Labels
None yet
Projects
None yet
Milestone
1.49.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@mherrmann @kjozwiak