Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Reading list graphics #17605

Merged
merged 1 commit into from
Mar 18, 2023
Merged

Fix Reading list graphics #17605

merged 1 commit into from
Mar 18, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 15, 2023

Resolves brave/brave-browser#24927

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • open sidebar
  • check bookmark page icon

@spylogsster spylogsster self-assigned this Mar 15, 2023
@spylogsster spylogsster force-pushed the brave-24927 branch 4 times, most recently from 8a4a2ce to 4de72ff Compare March 15, 2023 12:26
@spylogsster spylogsster changed the title wip: Fix Reading list graphics Fix Reading list graphics Mar 15, 2023
@spylogsster spylogsster marked this pull request as ready for review March 15, 2023 12:46
@spylogsster spylogsster requested review from a team as code owners March 15, 2023 12:46
"images/read_later_empty_dark.svg",
"images/read_later_empty.svg",
]
-
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an empty line got removed by accident.

Copy link
Contributor Author

@spylogsster spylogsster Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed patch as discussed in Slack

@spylogsster spylogsster force-pushed the brave-24927 branch 2 times, most recently from 5c585a1 to 36d7d29 Compare March 16, 2023 07:25
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@spylogsster spylogsster merged commit 6477d18 into master Mar 18, 2023
@spylogsster spylogsster deleted the brave-24927 branch March 18, 2023 05:10
@github-actions github-actions bot added this to the 1.51.x - Nightly milestone Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update introductory graphic for Reading list panel
3 participants