Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throttle "Feed parsing" requests (uplift to 1.50.x) #17874

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Throttle "Feed parsing" requests (uplift to 1.50.x) #17874

merged 1 commit into from
Apr 4, 2023

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Apr 3, 2023 •
edited by kjozwiak
Loading

Uplift of #17852
Resolves brave/brave-browser#29438

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@sangwoo108
Throttle "Feed parsing" requests
c599c04 
When a site has a lot off rss feed sites and the workload is quite heavy,
browser process starves and CPU spikes. In order to avoid that, throttle
parsing requests with task queue.
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@sangwoo108 sangwoo108 marked this pull request as ready for review April 3, 2023 05:54
@sangwoo108 sangwoo108 requested a review from a team as a code owner April 3, 2023 05:54
@kjozwiak kjozwiak added this to the 1.50.x - Release milestone Apr 4, 2023
kjozwiak
kjozwiak approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.50.x approved 👍 QA has verified the PR on Nightly as per #17852 (comment)..

@kjozwiak kjozwiak merged commit 2b562ca into 1.50.x Apr 4, 2023
@kjozwiak kjozwiak deleted the pr17852_sko/news-hang_1.50.x branch April 4, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@sangwoo108 sangwoo108

Labels
None yet
Projects
None yet
Milestone
1.50.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@sangwoo108 @kjozwiak