Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BR flag image to vpn panel #18073

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Added BR flag image to vpn panel #18073

merged 1 commit into from
Apr 14, 2023

Conversation

simonhong
Copy link
Member

fix brave/brave-browser#29719

Screenshot 2023-04-14 at 10 15 59 PM

Filed f/u issue (brave/brave-browser#29727) - serve flag icon from leo.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch with clean profile
  2. Set purchased state
  3. Open vpn panel and check brazil flag image

@simonhong simonhong requested a review from a team as a code owner April 14, 2023 13:50
@simonhong simonhong self-assigned this Apr 14, 2023
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 14, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GRD ++

@bsclifton bsclifton merged commit c7d2ca5 into master Apr 14, 2023
@bsclifton bsclifton deleted the add_br_flag_vpn branch April 14, 2023 18:29
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 14, 2023
brave-builds added a commit that referenced this pull request Apr 14, 2023
brave-builds added a commit that referenced this pull request Apr 14, 2023
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.52.47 Chromium: 112.0.5615.121 (Official Build) nightly (x86_64)
Revision 39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS macOS Version 11.7.6 (Build 20G1231)

Steps:

  1. installed 1.52.47
  2. purchased, configured, and connected to Brave VPN
  3. clicked on the VPN button on the toolbar
  4. confirmed flag in Brazil entry
  5. clicked Connect

Confirmed the flag of Brazil appeared in both places

Dark, server list Light, server list
Screen Shot 2023-04-15 at 2 41 50 AM Screen Shot 2023-04-15 at 2 42 23 AM
Dark, connection status Light, connection status
Screen Shot 2023-04-15 at 2 43 13 AM Screen Shot 2023-04-15 at 2 42 32 AM

kjozwiak pushed a commit that referenced this pull request Apr 17, 2023
kjozwiak pushed a commit that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Needs flag image for brazil region in vpn panel
5 participants