Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift of Remove PurchasedState::INVALID from BraveVpnService (#18147) #18258

Merged
merged 1 commit into from
May 2, 2023
Merged

Uplift of Remove PurchasedState::INVALID from BraveVpnService (#18147) #18258

merged 1 commit into from
May 2, 2023

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Apr 26, 2023 •
edited by kjozwiak
Loading

Uplift of #18147
Resolves brave/brave-browser#29846

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@spylogsster spylogsster self-assigned this Apr 26, 2023
@spylogsster spylogsster marked this pull request as ready for review April 26, 2023 20:03
@spylogsster spylogsster requested a review from a team as a code owner April 26, 2023 20:03
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 26, 2023
@spylogsster spylogsster changed the title Ulift of Remove PurchasedState::INVALID from BraveVpnService (#18147) Uplift of Remove PurchasedState::INVALID from BraveVpnService (#18147) Apr 26, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster
Copy link
Contributor Author

Should be merged after #18260

@bsclifton bsclifton force-pushed the pr18147_brave-29846_1.51.x branch from 1a1f263 to 6421f45 Compare May 1, 2023 23:58
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@simonhong simonhong force-pushed the pr18147_brave-29846_1.51.x branch from 6421f45 to 5843962 Compare May 2, 2023 02:49
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak kjozwiak added this to the 1.51.x - Release milestone May 2, 2023
kjozwiak
kjozwiak approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.51.x approved 👍 QA has verified the PR on Nightly as per #18147 (comment).

@kjozwiak kjozwiak merged commit a591573 into 1.51.x May 2, 2023
@kjozwiak kjozwiak deleted the pr18147_brave-29846_1.51.x branch May 2, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@spylogsster spylogsster

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@spylogsster @brave-builds @kjozwiak