Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show favicon when alert indicator is visible #18275

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Apr 27, 2023

We shouldn't show both of them at the same time

Resolves brave/brave-browser#30021

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Play a video from a tab
  • Activate another tab
  • Make vertical tabs collapsed
    • Favicon of the tab that is playing video shouldn't be visible
    • Only speaker button should be visible.

We shouldn't show both of them at the same time
@sangwoo108 sangwoo108 marked this pull request as ready for review April 27, 2023 10:23
@sangwoo108 sangwoo108 merged commit 7441a5d into master Apr 28, 2023
@sangwoo108 sangwoo108 deleted the sko/favicon branch April 28, 2023 02:30
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone Apr 28, 2023
brave-builds added a commit that referenced this pull request May 2, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented May 4, 2023

Verification PASSED using

Brave | 1.53.19 Chromium: 113.0.5672.77 (Official Build) nightly (64-bit)
-- | --
Revision | c4236862955e005c2187105415ac4a2ecf86dff1-refs/branch-heads/5672_62@{#3}
OS | Windows 11 Version 22H2 (Build 22621.1555)
  1. Install 1.53.19
  2. launched Brave
  3. clicked Skip >> Skip >> Finish
  4. visited youtube.com (and couple of other audio playing sites)
  5. enabled vertical tabs via context menu
  6. played audio which is not the active tab
  7. mute/unmute audio playing tabs

Confirmed favicon is not shown for audio playing tab in collapsed state in the vertical tab panel

speaker button is visible while mute/unmute on the audio playing tab

Dark mode

Example Example Example Example
image image image image
Example Example
image image

kjozwiak pushed a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

speaker icon displays over page favicon in vertical tab mode with "Float on mouseover" selected
3 participants